Skip to content

test(fe): remove logout flow in login/logout flow test to focus on login process #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2024
Merged

test(fe): remove logout flow in login/logout flow test to focus on login process #248

merged 2 commits into from
Dec 3, 2024

Conversation

cjeongmin
Copy link
Collaborator

@cjeongmin cjeongmin commented Dec 3, 2024 •
edited
Loading

개요

  • 기존 로그인 / 로그아웃 프로세스 테스트에서 로그아웃 테스트를 제거했습니다.
  • 세션 접속시 페이지 타이틀에 세션 타이틀을 추가합니다.

@cjeongmin cjeongmin self-assigned this Dec 3, 2024
@cjeongmin cjeongmin requested a review from Copilot December 3, 2024 08:24
Copilot
Copilot AI reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

shl0501
shl0501 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wlgh1553
wlgh1553 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!!

@cjeongmin cjeongmin merged commit 2a11f78 into main Dec 3, 2024
2 checks passed
@wlgh1553 wlgh1553 deleted the test(fe)/fix branch December 3, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wlgh1553 wlgh1553 wlgh1553 approved these changes

@shl0501 shl0501 shl0501 approved these changes

@yu-yj215 yu-yj215 Awaiting requested review from yu-yj215

Assignees

@cjeongmin cjeongmin

Labels

Fix Test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cjeongmin @wlgh1553 @shl0501