Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to choose the theme using the device's default configuration #231

Open
tbouffard opened this issue Aug 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tbouffard
Copy link
Member

tbouffard commented Aug 8, 2024

We have recently added the support of the device's default configuration in #226.
But once we toggle the theme selector, there is no way (except if we remove the entry in the local storage which is far from being user friendly 😸 ).
Currently, we have a toggle button that only to select 2 state: dark or light.

image

To support a 3rd state (device default), we have to change the UI design of the selector.

Existing solution

web.dev

We could provide something like in the https://web.dev/?hl=en which provide tooltip on the selected theme icon as well.

web.dev_theme_selector.mp4

tailwindcss

https://tailwindcss.com/docs/dark-mode

tailwind-css.mp4
@tbouffard tbouffard added the enhancement New feature or request label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant