fix: add missing null checks around values

Also uses `getColumns` for note wrapping and changes the `types` script
to run `tsc` so we can catch these errors in CI in future.

Author: 43081j

.changeset/kind-yaks-clean.md

@@ -0,0 +1,6 @@
+---
+"@clack/prompts": patch
+"@clack/core": patch
+---
+
+Add missing nullish checks around values.

.editorconfig

@@ -7,6 +7,6 @@ charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
-[*.yml]
+[*.{yml,json,yaml}]
 indent_style = space
 indent_size = 2

package.json

@@ -9,7 +9,7 @@
     "dev": "pnpm --filter @example/changesets run start",
     "format": "biome check --write",
     "lint": "biome lint --write --unsafe",
-    "types": "biome lint --write --unsafe",
+    "types": "tsc --noEmit",
     "deps": "pnpm exec knip --production",
     "test": "pnpm --color -r run test",
     "pretest": "pnpm run build"

packages/core/src/prompts/multi-select.ts

@@ -21,7 +21,11 @@ export default class MultiSelectPrompt<T extends { value: any }> extends Prompt<
 	}
 
 	private toggleInvert() {
-		const notSelected = this.options.filter((v) => !this.value.includes(v.value));
+		const value = this.value;
+		if (!value) {
+			return;
+		}
+		const notSelected = this.options.filter((v) => !value.includes(v.value));
 		this.value = notSelected.map((v) => v.value);
 	}
 

packages/core/tsconfig.json

@@ -1,3 +1,4 @@
 {
-  "extends": "../../tsconfig.json"
+  "extends": "../../tsconfig.json",
+  "include": ["src"]
 }

packages/prompts/src/note.ts

@@ -1,6 +1,7 @@
 import process from 'node:process';
 import type { Writable } from 'node:stream';
 import { stripVTControlCharacters as strip } from 'node:util';
+import { getColumns } from '@clack/core';
 import { wrapAnsi } from 'fast-wrap-ansi';
 import color from 'picocolors';
 import {
@@ -13,13 +14,14 @@ import {
 	S_STEP_SUBMIT,
 } from './common.js';
 
+type FormatFn = (line: string) => string;
 export interface NoteOptions extends CommonOptions {
-	format?: (line: string) => string;
+	format?: FormatFn;
 }
 
 const defaultNoteFormatter = (line: string): string => color.dim(line);
 
-const wrapWithFormat = (message: string, width: number, format: NoteOptions['format']): string => {
+const wrapWithFormat = (message: string, width: number, format: FormatFn): string => {
 	const wrapMsg = wrapAnsi(message, width).split('\n');
 	const maxWidthNormal = wrapMsg.reduce((sum, ln) => Math.max(strip(ln).length, sum), 0);
 	const maxWidthFormat = wrapMsg
@@ -32,7 +34,7 @@ const wrapWithFormat = (message: string, width: number, format: NoteOptions['for
 export const note = (message = '', title = '', opts?: NoteOptions) => {
 	const output: Writable = opts?.output ?? process.stdout;
 	const format = opts?.format ?? defaultNoteFormatter;
-	const wrapMsg = wrapWithFormat(message, output.columns - 6, format);
+	const wrapMsg = wrapWithFormat(message, getColumns(output) - 6, format);
 	const lines = ['', ...wrapMsg.split('\n').map(format), ''];
 	const titleLen = strip(title).length;
 	const len =

packages/prompts/test/__snapshots__/note.test.ts.snap

@@ -65,8 +65,8 @@ describe.each(['true', 'false'])('note (isCI = %s)', (isCI) => {
 	});
 
 	test("don't overflow", () => {
-		const input = `${'test string '.repeat(32)}\n`.repeat(4).trim();
-		prompts.note(input, 'title', {
+		const message = `${'test string '.repeat(32)}\n`.repeat(4).trim();
+		prompts.note(message, 'title', {
 			input,
 			output: Object.assign(output, { columns: 75 }),
 		});
@@ -75,8 +75,8 @@ describe.each(['true', 'false'])('note (isCI = %s)', (isCI) => {
 	});
 
 	test("don't overflow with formatter", () => {
-		const input = `${'test string '.repeat(32)}\n`.repeat(4).trim();
-		prompts.note(input, 'title', {
+		const message = `${'test string '.repeat(32)}\n`.repeat(4).trim();
+		prompts.note(message, 'title', {
 			format: (line) => colors.red(`* ${colors.cyan(line)} *`),
 			input,
 			output: Object.assign(output, { columns: 75 }),

packages/prompts/test/note.test.ts

@@ -77,7 +77,7 @@ describe.each(['true', 'false'])('password (isCI = %s)', (isCI) => {
 		const result = prompts.password({
 			message: 'foo',
 			validate: (value) => {
-				if (value.length < 2) {
+				if (!value || value.length < 2) {
 					return 'Password must be at least 2 characters';
 				}
 

packages/prompts/test/password.test.ts

@@ -1,3 +1,4 @@
 {
-  "extends": "../../tsconfig.json"
+  "extends": "../../tsconfig.json",
+  "include": ["src"]
 }