From 237c453c2da7d549b9bdb2c044ba284fbb9d9ba7 Mon Sep 17 00:00:00 2001 From: Theodor Mihalache <84387487+tmihalac@users.noreply.github.com> Date: Mon, 28 Oct 2024 10:08:22 -0400 Subject: [PATCH] fix: Feast create empty online table when FeatureView attribute online=False (#4666) Signed-off-by: Theodor Mihalache --- sdk/python/feast/infra/passthrough_provider.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sdk/python/feast/infra/passthrough_provider.py b/sdk/python/feast/infra/passthrough_provider.py index a1e9ef82ad..215b175eb2 100644 --- a/sdk/python/feast/infra/passthrough_provider.py +++ b/sdk/python/feast/infra/passthrough_provider.py @@ -148,10 +148,16 @@ def update_infra( ): # Call update only if there is an online store if self.online_store: + tables_to_keep_online = [ + fv + for fv in tables_to_keep + if not hasattr(fv, "online") or (hasattr(fv, "online") and fv.online) + ] + self.online_store.update( config=self.repo_config, tables_to_delete=tables_to_delete, - tables_to_keep=tables_to_keep, + tables_to_keep=tables_to_keep_online, entities_to_keep=entities_to_keep, entities_to_delete=entities_to_delete, partial=partial,