Implement MLSD & fix MLST #541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
procr1337
changed the title
procr1337
changed the title
|
Small issue, I believe the rfc states that all facts must end with a ';', even the last one. |
Author
|
@LLeny you are absolutely right, thank you! I didn't encounter any issues in my testing with rclone however |
|
@procr1337 For reference, I did, there: LLeny/proton-drive-bridge#9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: A lot of this code was written with AI assistance. I reviewed it & improved the test coverage.
Additional fixes (in separate commits which can be cherry-picked if needed):
213 <facts> filename, where it should be a multi-line format initiated by250-and ended by250, as per https://datatracker.ietf.org/doc/html/rfc3659#section-7.2facts = 1*( fact ";" )Since async_ftp does not support MLST nor MLSD, we (Claude and me :) added manual TCP-based tests for both commands in the existing sbe-fs integration test suite. This is obviously weaker since we don't have a compliant client to check against. In addition, I manually tested this against rclone's FTP client and FileZilla.