Skip to content

Commit e1e092f

Browse files
authored
Minor API cleanup (nodejs#176)
- Make env parameter name consistent in header - Remove napi_get_cb_holder; it is not used anywhere. We can add it back later if it's really needed.
1 parent 1fc1181 commit e1e092f

File tree

2 files changed

+85
-105
lines changed

2 files changed

+85
-105
lines changed

src/node_api.cc

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1411,22 +1411,6 @@ napi_status napi_get_cb_this(napi_env e,
14111411
return napi_ok;
14121412
}
14131413

1414-
// Holder is a V8 concept. Is not clear if this can be emulated with other VMs
1415-
// AFAIK Holder should be the owner of the JS function, which should be in the
1416-
// prototype chain of This, so maybe it is possible to emulate.
1417-
napi_status napi_get_cb_holder(napi_env e,
1418-
napi_callback_info cbinfo,
1419-
napi_value* result) {
1420-
// Omit NAPI_PREAMBLE and GET_RETURN_STATUS because no V8 APIs are called.
1421-
CHECK_ARG(result);
1422-
1423-
v8impl::CallbackWrapper* info =
1424-
reinterpret_cast<v8impl::CallbackWrapper*>(cbinfo);
1425-
1426-
*result = info->Holder();
1427-
return napi_ok;
1428-
}
1429-
14301414
napi_status napi_get_cb_data(napi_env e,
14311415
napi_callback_info cbinfo,
14321416
void** result) {

0 commit comments

Comments
 (0)