GP-127 PR review is resolved

Author: shryhus

3-0-jpa-and-hibernate/3-1-1-employee-profile/src/test/java/com/bobocode/EmployeeProfileMappingTest.java

@@ -32,7 +32,7 @@ static void destroy() {
 
     @Test
     @Order(1)
-    @DisplayName("The employee table has correct name")
+    @DisplayName("The employee table has a correct name")
     void employeeTableHasCorrectName() {
         Table table = Employee.class.getAnnotation(Table.class);
         String tableName = table.name();
@@ -53,7 +53,7 @@ void saveEmployeeOnly() {
 
     @Test
     @Order(3)
-    @DisplayName("Save an employee without email")
+    @DisplayName("Saving an employee throws an exception when the email is null")
     void saveEmployeeWithoutEmail() {
         Employee employee = createRandomEmployee();
         employee.setEmail(null);
@@ -64,7 +64,7 @@ void saveEmployeeWithoutEmail() {
 
     @Test
     @Order(4)
-    @DisplayName("Save an employee without first name")
+    @DisplayName("Saving an employee throws an exception when the first name is null")
     void saveEmployeeWithoutFirstName() {
         Employee employee = createRandomEmployee();
         employee.setFistName(null);
@@ -75,7 +75,7 @@ void saveEmployeeWithoutFirstName() {
 
     @Test
     @Order(5)
-    @DisplayName("Save an employee without last name")
+    @DisplayName("Saving an employee throws an exception when the last name is null")
     void testSaveEmployeeWithoutLastName() {
         Employee employee = createRandomEmployee();
         employee.setLastName(null);
@@ -86,7 +86,7 @@ void testSaveEmployeeWithoutLastName() {
 
     @Test
     @Order(6)
-    @DisplayName("The employee profile table has correct name")
+    @DisplayName("The employee profile table has a correct name")
     void employeeProfileTableHasCorrectName() {
         Table table = EmployeeProfile.class.getAnnotation(Table.class);
         String tableName = table.name();
@@ -96,7 +96,7 @@ void employeeProfileTableHasCorrectName() {
 
     @Test
     @Order(7)
-    @DisplayName("Save only a profile of employee")
+    @DisplayName("Save only an employee profile")
     void saveEmployeeProfileOnly() {
         EmployeeProfile employeeProfile = createRandomEmployeeProfile();
         employeeProfile.setId(666L);
@@ -156,7 +156,7 @@ void addEmployeeProfile() {
 
     @Test
     @Order(11)
-    @DisplayName("Add employee profile without position")
+    @DisplayName("Adding an employee profile throws an exception when the position is null")
     void addEmployeeWithoutPosition() {
         Employee employee = createRandomEmployee();
         emUtil.performWithinTx(entityManager -> entityManager.persist(employee));
@@ -175,7 +175,7 @@ void addEmployeeWithoutPosition() {
 
     @Test
     @Order(12)
-    @DisplayName("Add employee profile without department")
+    @DisplayName("Adding an employee profile throws an exception when the department is null")
     void addEmployeeWithoutDepartment() {
         Employee employee = createRandomEmployee();
         emUtil.performWithinTx(entityManager -> entityManager.persist(employee));

3-0-jpa-and-hibernate/pom.xml

@@ -23,7 +23,7 @@
         <dependency>
             <groupId>org.postgresql</groupId>
             <artifactId>postgresql</artifactId>
-            <version>42.2.23.jre7</version>
+            <version>42.2.23</version>
         </dependency>
         <dependency>
             <groupId>com.h2database</groupId>
@@ -45,7 +45,7 @@
         <dependency>
             <groupId>javax.xml.bind</groupId>
             <artifactId>jaxb-api</artifactId>
-            <version>2.4.0-b180830.0359</version>
+            <version>2.3.1</version>
         </dependency>
 
         <dependency>