fix: allow buffer, use correct oft, check viem clients

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Author: gregdhill

sdk/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gobob/bob-sdk",
-    "version": "4.2.3",
+    "version": "4.2.4",
     "main": "dist/index.js",
     "types": "dist/index.d.ts",
     "scripts": {
@@ -52,4 +52,4 @@
         "viem": "^2.33.2",
         "global": "^4.4.0"
     }
-}
+}

sdk/src/gateway/layerzero.ts

@@ -137,6 +137,12 @@ export class LayerZeroGatewayClient extends GatewayApiClient {
                 throw new Error(`Unsupported destination chain: ${toChain}`);
             }
 
+            // always use the wBTC token on BOB
+            const wbtcOftAddress = await this.l0Client.getOftAddressForChain('bob');
+            if (!wbtcOftAddress) {
+                throw new Error(`WBTC OFT not found for chain: ${fromChain}`);
+            }
+
             // TODO: Will need to generalize this if we want to support other option sets. Its manual ABI encoding so a little complex.
             const extraOptions = encodePacked(
                 ['uint16', 'uint8', 'uint16', 'uint8', 'uint128'],
@@ -166,16 +172,17 @@ export class LayerZeroGatewayClient extends GatewayApiClient {
 
             // Getting the layer zero fee gas so we know how much we need to swap from the order
             const layerZeroFee = await publicClient.readContract({
-                address: params.toToken as Hex,
+                address: wbtcOftAddress as Hex,
                 abi: layerZeroOftAbi,
                 functionName: 'quoteSend',
                 args: [sendParam, false],
             });
 
-            const buffer = BigInt(500); // 5% buffer
+            // allow consumer to override the buffer
+            const buffer = params.l0FeeBuffer ? BigInt(params.l0FeeBuffer) : BigInt(500); // 5% buffer
 
             // Add buffer to the layer zero fee to account for changes from now until the order is executed
-            const layerZeroFeeWithBuffer = (layerZeroFee.nativeFee * (10000n + buffer)) / 10000n; // 5% buffer
+            const layerZeroFeeWithBuffer = (layerZeroFee.nativeFee * (10000n + buffer)) / 10000n;
 
             // Getting the amount of tokens we need to swap from the order by using the uniswap quoter
             const quote = await publicClient.readContract({
@@ -184,7 +191,7 @@ export class LayerZeroGatewayClient extends GatewayApiClient {
                 functionName: 'quoteExactOutputSingle',
                 args: [
                     {
-                        tokenIn: params.toToken as Hex,
+                        tokenIn: wbtcOftAddress as Hex,
                         tokenOut: '0x4200000000000000000000000000000000000006' as Hex,
                         amountOut: layerZeroFeeWithBuffer, // Desired output amount
                         fee: 3000,
@@ -256,10 +263,10 @@ export class LayerZeroGatewayClient extends GatewayApiClient {
             const receiverAddress = toHexScriptPubKey(params.toUserAddress, bitcoin.networks.bitcoin);
 
             const dstEid = await layerZeroClient.getEidForChain('bob');
-
             if (!dstEid) {
                 throw new Error(`Destination EID not found for chain: ${fromChain}`);
             }
+
             const wbtcOftAddress = await layerZeroClient.getOftAddressForChain(fromChain);
             if (!wbtcOftAddress) {
                 throw new Error(`WBTC OFT not found for chain: ${fromChain}`);
@@ -307,6 +314,11 @@ export class LayerZeroGatewayClient extends GatewayApiClient {
                 ),
             };
 
+            // we're quoting on the origin chain, so public client must be configured correctly
+            if (publicClient.chain?.name.toLowerCase() !== fromChain) {
+                throw new Error(`Public client must be origin chain`);
+            }
+
             const sendFees = await publicClient.readContract({
                 abi: layerZeroOftAbi,
                 address: wbtcOftAddress as Hex,

sdk/src/gateway/types.ts

@@ -95,6 +95,9 @@ export interface GatewayQuoteParams {
 
     /** @description Cross chain message - strategy data */
     message?: Hex;
+
+    /** @description LayerZero fee buffer percentage in Basis Points (BPS) units to add on top of the estimated L0 fee. This accounts for potential L0 fee changes between quote time and order execution. Default is 500 BPS (5%). */
+    l0FeeBuffer?: number | bigint;
 }
 
 /**

sdk/test/layerzero.test.ts

@@ -65,7 +65,7 @@ describe('LayerZero Tests', () => {
         assert.equal(await client.getOftAddressForChain('sei'), '0x0555e30da8f98308edb960aa94c0db47230d2b9c');
     }, 120000);
 
-    it('should get an onramp quote and execute it', async () => {
+    it.skip('should get an onramp quote and execute it', async () => {
         const client = new LayerZeroGatewayClient(bob.id);
 
         const quote = await client.getQuote({
@@ -104,7 +104,7 @@ describe('LayerZero Tests', () => {
         console.log(txHash);
     }, 120000);
 
-    it('should get an offramp quote and execute it', async () => {
+    it.skip('should get an offramp quote and execute it', async () => {
         const client = new LayerZeroGatewayClient(bob.id);
         const layerZeroClient = new LayerZeroClient();