-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong description of rotate_left/right #158
Comments
Confirming this issue! |
@MathieuDerelle , thank you for opening this issue. @SlavaEremenko , thank you for confirming this issue. Although I haven't tested this issue yet, I suspect that the biggest question I will have with this issue is "how to fix it?":
I think this change / fix will require a version bump due to it being a breaking change. I'll think about this some more and would be happy to read your input. Kindly, |
I think If you imagine a circle, rotating left could mean
You could define those 2 methods : |
I agree with both of you. Keep the old methods, deprecate them, put a note into the docs and create new methods: |
the source code says
but from what I've tested, it's the opposite, rotate_left is rotating clockwise et rotate_right counter clockwise
The text was updated successfully, but these errors were encountered: