Refactor TemporalFields interface and add FieldsKey enum
#87
Conversation
src/fields.rs
Outdated
| time_zone: None, | ||
| } | ||
| } | ||
| properties: FxHashMap<FieldKey, FieldValue>, |
There was a problem hiding this comment.
Overall question. Why do we need to use a hashmap? I would say having a map-like interface for the current struct approach would also work well, with the advantage of being all in the stack.
There was a problem hiding this comment.
Hmmmm, changing the interface might work as well.
I'm not entirely sure how much of a fan I am of the large struct that this switches away from, but it could also primarily be the API for the struct that I'm annoyed by.
I'll play around with it a bit more 😄
|
Marking as ready for review. I think this is an improvement interface/API wise vs. the old methods. If anyone has suggestions, let me know. |
nekevss
changed the title
TemporalFields to a HashMap vs the static struct.TemporalFields interface and add FieldsKey enum
|
Hmmmm, I do sort like the idea. If it makes the API easy to use and the code a tad cleaner / easier to reason through, then I don't see a reason to not try. |
This refactors the representation to
TemporalFields. The previous implementation was a bit cumbersome. This is meant to trim down the implementation and, hopefully, make the API a simpler.