Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some missing trait implementations #81

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Add some missing trait implementations #81

merged 2 commits into from
Jul 16, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 12, 2024

Mostly adding some missing From implementations according to values that may be convertible, and a FromStr for Time.

@nekevss nekevss added the C-api Changes related to the public API label Jul 12, 2024
jedel1043
jedel1043 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nekevss nekevss merged commit f133197 into main Jul 16, 2024
5 checks passed
@jedel1043 jedel1043 deleted the add-missing-trait-impls branch July 16, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
C-api Changes related to the public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekevss @jedel1043