Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String.matchAll(regexp) #115

Closed
jasonwilliams opened this issue Sep 27, 2019 · 2 comments
Closed

String.matchAll(regexp) #115

jasonwilliams opened this issue Sep 27, 2019 · 2 comments
Assignees
@bojan88
Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Milestone
Full Regular Expr...

Comments

@jasonwilliams
Copy link
Member

jasonwilliams commented Sep 27, 2019 •
edited
Loading

matchAll function would need to be added to the string object here:
https://github.com/jasonwilliams/boa/blob/master/src/lib/js/string.rs

It would be very similar to:
https://github.com/jasonwilliams/boa/blob/master/src/lib/js/regexp.rs#L212-L251

Spec:
https://tc39.es/ecma262/#sec-string.prototype.matchAll

Notes:
https://github.com/jasonwilliams/boa/blob/master/docs/debugging.md
@jasonwilliams jasonwilliams added this to the Regex milestone Sep 27, 2019
@jasonwilliams jasonwilliams added good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com labels Sep 27, 2019
@bojan88
Copy link
Contributor

bojan88 commented Oct 2, 2019

@jasonwilliams thanks for nice and straightforward issue. I'm going to start working on this one.

@jasonwilliams
Copy link
Member Author

@bojan88 great, assigned!

@muskuloes muskuloes mentioned this issue Oct 5, 2019
Closed
@bojan88 bojan88 mentioned this issue Oct 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bojan88 bojan88

Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
Full Regular Expression support
Development

No branches or pull requests
2 participants
@jasonwilliams @bojan88