Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid C4819 and its disasters #58

Open
DuKeM-CSGO opened this issue May 5, 2023 · 1 comment
Open

Avoid C4819 and its disasters #58

DuKeM-CSGO opened this issue May 5, 2023 · 1 comment

Comments

@DuKeM-CSGO
Copy link

F:\Github\v8-cmake-master\v8\src\objects\js-temporal-objects.cc(5873,41): error C2065: "temp": undeclared identifier [F:\v8_build\v8_base_without_compiler.vcxproj]
F:\Github\v8-cmake-master\v8\src\objects\js-temporal-objects.cc(5879,62): error C2059: syntax error: ")" [F:\v8_build\v8_base_without_compiler.vcxproj]
F:\Github\v8-cmake-master\v8\src\objects\js-temporal-objects.cc(5880,15): error C2039: "ToHandleChecked": Not the member of "v8::internal::Handle<v8::internal::BigInt>" [F:\v8_build\v8_base_without_compiler.vcxproj]

What's strange is when I open v8_base_without_compiler.vcxproj in VS 2022, the IntelliSense works and doesn't treat them as errors. I don't use code page 65001. Maybe the char in line 5866 or something else doesn't be read right, I guess.

Originally posted by @DuKeM-CSGO in #57 (comment)

May consider adding "/utf-8" to target_compile_option in the CMakelists.txt to avoid this issue, especially when the projects aren't generated in the code page 65001.

@bnoordhuis
Copy link
Owner

cc @gengjiawen as our resident Windows guru.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants