Skip to content

Commit

Permalink
Update to node 22.9.0
Browse files Browse the repository at this point in the history
Note the V8 version didn't change between 22.7.0 and 22.9.0 although
Node.js did add a new API in nodejs/node#54279

Remove unused and/or unnecessary patches. Upstream disabled Maglev so
we no longer have to do that manually. The genv8constants.py patches
were for a script that I removed upstream last year.
  • Loading branch information
bnoordhuis committed Sep 18, 2024
1 parent 655fbea commit f44c672
Show file tree
Hide file tree
Showing 10 changed files with 4 additions and 143 deletions.
4 changes: 2 additions & 2 deletions lib/libv8/node/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Libv8
end

module Libv8::Node
VERSION = '22.7.0.4'
NODE_VERSION = '22.7.0'
VERSION = '22.9.0.0'
NODE_VERSION = '22.9.0'
LIBV8_VERSION = '12.4.254.21' # from src/node-.../deps/v8/include/v8-version.h
end
2 changes: 1 addition & 1 deletion libexec/build-libv8
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ cd "${src}/node-v${version}"

# Maglev is disabled because of a suspected x64 snapshot regression in
# DoComputeOutputFrames
configure_flags='--v8-disable-maglev --openssl-no-asm --without-npm --shared --with-intl=full-icu'
configure_flags='--openssl-no-asm --without-npm --shared --with-intl=full-icu'
eval "$("${libexec}/platform")"

echo "configure: ${configure_flags}"
Expand Down
16 changes: 0 additions & 16 deletions libexec/extract-node
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,5 @@ extract "${src}" "${src}/node-v${version}.tar.gz"

cd "${src}/node-v${version}"

#patch -p1 < "${top}"/patch/gyp-libv8_monolith.patch
#patch -p1 < "${top}"/patch/py2-icutrim.patch
#patch -p1 < "${top}"/patch/py2-genv8constants.patch
patch -p1 < "${top}"/patch/v8-no-assert-trivially-copyable.patch
patch -p1 < "${top}"/patch/v8-disable-madv-dontfork.patch
patch -p1 < "${top}"/patch/v8-disable-pkey.patch
patch -p1 < "${top}"/patch/v8-disable-marking.patch

# TODO: the following still fails on py3 so the above one forcing py2 is needed
# patch -p1 < ../../py3-genv8constants.patch
#
# This is the error:
#
# Traceback (most recent call last):
# File "tools/genv8constants.py", line 99, in <module>
# curr_val += int('0x%s' % octetstr, 16) << (curr_octet * 8)
# ValueError: invalid literal for int() with base 16: "0xb'04 '"
# node_dtrace_ustack.target.mk:13: recipe for target '/usbkey/user_home/vagrant/ruby-libv8-node/src/node-14.14.0/out/Release/obj/gen/v8constants.h' failed
44 changes: 0 additions & 44 deletions patch/gyp-libv8_monolith.patch

This file was deleted.

10 changes: 0 additions & 10 deletions patch/py2-genv8constants.patch

This file was deleted.

14 changes: 0 additions & 14 deletions patch/py2-icutrim.patch

This file was deleted.

20 changes: 0 additions & 20 deletions patch/py3-genv8constants.patch

This file was deleted.

22 changes: 0 additions & 22 deletions patch/v8-disable-marking.patch

This file was deleted.

14 changes: 0 additions & 14 deletions patch/v8-no-assert-trivially-copyable.patch

This file was deleted.

1 change: 1 addition & 0 deletions sums/v22.9.0.sum
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
296854aa1dca140b0462c2415637d0419e42af91114538a7e6fdf623971a6833

0 comments on commit f44c672

Please sign in to comment.