-
-
Notifications
You must be signed in to change notification settings - Fork 305
more lenient osgi.ee=JavaSE for unknown JDKs #6859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
more lenient osgi.ee=JavaSE for unknown JDKs #6859
Conversation
3f533d5 to
c63fede
Compare
c63fede to
8d418ec
Compare
|
In the advent of regular Java versions released this seems the right approach. In general the EE enum might needs to be revised by:
|
|
@chrisrueger I have fired up a task for the AI here maybe it produces something useful as a base-ground: |
Just adding that currently there are two enums holding Java versions:
|
For a yet to bnd unknown JDK (e.g. JDK-10000) Instead of ``` Require-Capability: osgi.ee;filter:="(osgi.ee=UNKNOWN)" ``` we now create Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=9955))" for a .class file with u2 major_version 10000 (9955 == 10000 - 45) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
8d418ec to
93558d3
Compare
|
Selecting a ee from bndrun files is a little hard when there are so many list items available. Maybe we can downsize a little. |
|
Feel free to downsize whatever I did in https://github.com/bndtools/bnd/pull/6891/files :) |
mY recommendation would be to replace dropdowns by a spinner or something instead in the UI |
Closes #6858
Experimental:
For a yet to bnd unknown JDK (e.g. JDK-10000) Instead of
we now create
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=9955))"
for a .class file with u2 major_version 10000 (9955 == 10000 - 45)