Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When trying to prune with pruneancient, the program cannot continue and the error message is wrong #1074

Closed
ottodevs opened this issue Aug 31, 2022 · 3 comments
Assignees

Comments

@ottodevs
Copy link

Hi, It seems confusing logging this as a warning, when it is causing an unrecoverable error, so why not directly an error?

The message, seems cryptic, I think it can be improved to be human readable? What does it mean "can add pruneancient parameter resolve"???, Interpreting and following the recommended advice does not work, geth snapshot prune-state does not accept any pruneancient parameter at all...

Apart from that, the message contains a typo "ancinet"

So I guess this logic was added without proper review, at least the message is not telling a valid way to solve the issue...

log.Warn("prune ancinet flag is set, may start fail, can add pruneancient parameter resolve")

Is there an actual correct way to launch geth snapshot prune-state when regular geth execution contains pruneancient=true ?

@ottodevs
Copy link
Author

By reading the code, I see there is no an actual way to prune the node with pruneancient enabled, maybe I am missing something or is not needed at all, but those lines of code check if the db is PruneFreezerType then throws the error, there doesn't seem to be any alternative logic to bypass this error based on any extra parameter, so it seems the error I quoted it is just misleading the node operator.

@ottodevs
Copy link
Author

Related to #1034

@owen-reorg
Copy link

It seems this issue had been fixed by #1053 and released in v1.1.13.

Please try with the new binary.

And we'll optimize the error message to make it more clear in further releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants