Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark 10.x version #3

Open
Jabher opened this issue May 14, 2018 · 5 comments
Open

Benchmark 10.x version #3

Jabher opened this issue May 14, 2018 · 5 comments

Comments

@Jabher
Copy link

Jabher commented May 14, 2018

Hi. I've benchmarked node 10 and see it has significant performance decrease, it probably should appear here.
I'm not sure about proper test conditions (I've ran it on windows linux subsystem), so - can you please run it on same machine as other tests?

My results are

# Node 9.11.1 
/m/c/U/c/W/async-hooks-performance-impact (master) $ node run.js
regular Bluebird-doxbee: 238 ms.
init Bluebird-doxbee: 475 ms.
full Bluebird-doxbee: 595 ms.
regular Bluebird-parallel: 946 ms.
init Bluebird-parallel: 1657 ms.
full Bluebird-parallel: 1793 ms.
regular Wikipedia: 1256 ms.
init Wikipedia: 2368 ms.
full Wikipedia: 2713 ms.

# Node 10.0.1 
/m/c/U/c/W/async-hooks-performance-impact (master) $ node run.js
regular Bluebird-doxbee: 262 ms.
init Bluebird-doxbee: 771 ms.
full Bluebird-doxbee: 1068 ms.
regular Bluebird-parallel: 556 ms.
init Bluebird-parallel: 1583 ms.
full Bluebird-parallel: 1942 ms.
regular Wikipedia: 878 ms.
init Wikipedia: 3876 ms.
full Wikipedia: 3345 ms.
@bmeurer
Copy link
Owner

bmeurer commented May 14, 2018

Not just that, it also has serious correctness regressions. We're currently reverting most of the async/Promise performance improvements for Node 10, so performance-wise it should soon be the same as Node 9 again.

@mawrkus
Copy link

mawrkus commented Dec 20, 2018

Hi,
I also observed a significant increase of CPU usage on a production server running Hapi 17 on Node 10.14.2.
I read the conversation nodejs/benchmarking#181, do you know if there's some progress on this? Or should I consider going back to domains as a temporary alternative?

@bmeurer
Copy link
Owner

bmeurer commented Dec 20, 2018

There's no clear decision what to do with the async_hooks. I guess for Node 10 you'll just need to revert to an alternative if it's a serious problem for now.

@mawrkus
Copy link

mawrkus commented Dec 21, 2018

Ok, thanks.

@rambo-panda
Copy link

share ...

process version

 {
  node: '16.11.1',
  v8: '9.4.146.19-node.13',
  uv: '1.42.0',
  zlib: '1.2.11',
  brotli: '1.0.9',
  ares: '1.17.2',
  modules: '93',
  nghttp2: '1.45.1',
  napi: '8',
  llhttp: '6.0.4',
  openssl: '1.1.1l+quic',
  cldr: '39.0',
  icu: '69.1',
  tz: '2021a',
  unicode: '13.0',
  ngtcp2: '0.1.0-DEV',
  nghttp3: '0.1.0-DEV'
}

regular Bluebird-doxbee: 96 ms.
init Bluebird-doxbee: 146 ms.
full Bluebird-doxbee: 424 ms.
regular Bluebird-parallel: 136 ms.
init Bluebird-parallel: 221 ms.
full Bluebird-parallel: 757 ms.
regular Wikipedia: 342 ms.
init Wikipedia: 532 ms.
full Wikipedia: 1339 ms.
regular hapiserver: 11094 reqs.
init hapiserver: 9570.19 reqs.
full hapiserver: 5749.37 reqs.
regular koaserver: 15356.73 reqs.
init koaserver: 15366.4 reqs.
full koaserver: 13534.4 reqs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants