Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value for delimiter is not Windows-friendly #6

Closed
nexdrew opened this issue Dec 22, 2017 · 1 comment
Closed

Default value for delimiter is not Windows-friendly #6

nexdrew opened this issue Dec 22, 2017 · 1 comment

Comments

@nexdrew
Copy link
Contributor

nexdrew commented Dec 22, 2017

See conventional-changelog/standard-version#230 (comment)

In order to use this library in a Windows-friendly way, you have to change the default delimiter value. Seems like it would be better to default to require('path').sep instead, so that matching against os-specific paths would work cross-platform out of the box.
@ljharb
Copy link
Collaborator

ljharb commented Dec 22, 2017

Seems reasonable. Want to submit a PR?

@nexdrew nexdrew mentioned this issue Jan 5, 2018
Merged
@ljharb ljharb closed this as completed in #7 Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @nexdrew