Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArrayVec::drain_filter() #95

Closed
wants to merge 2 commits into from
Closed

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Feb 22, 2018

This adds drain_filter() with an implementation similar to Vec's nightly drain_filter(). Can also be used to simplify retain().

@bluss
Copy link
Owner

bluss commented Mar 10, 2018

Thanks, this looks good! unstable drain_filter in Rust seems a bit volatile, so I'd like to avoid merging this until we are confident it matches the upstream shape of the API. The alternative would be to merge it, but remove it in arrayvec 1.0.

See rust-lang/rust#43244

@niklasf
Copy link
Contributor Author

niklasf commented Mar 10, 2018

Makes sense. Let's put it on hold.

@bluss
Copy link
Owner

bluss commented Nov 25, 2018

Hm, still no movement on the tracking issue.

@niklasf
Copy link
Contributor Author

niklasf commented Jul 17, 2019

Possibly relevant, one day: rust-lang/rust#61224

@niklasf
Copy link
Contributor Author

niklasf commented Oct 8, 2021

Will have to be rewritten, when the time comes (due to merge conflicts).

@niklasf niklasf closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants