-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide authorisation/security information to kafka producer. #256
Comments
While it is possible to extend the set of command line arguments, I don't think it is the best way to go, since it is unlikely we could cover every possible scenario. It is likely that built-in options to create Run Engine and subscribe it to Data Broker or Kafka Publisher are going to be used only for demos and tutorials. In production deployments we create an instance of Run Engine (it must be a variable named |
I'm also inclined to think that Medium term, it might also be worth investigating something like what tiled does with handlers to have a config file that specifies what callbacks to attach the RE that it creates rather than passing this configuration through the command line. |
In production we set all callbacks in the startup code. I think that may be the default mode should be the one that uses Run Engine created in the startup scripts and the other mode should be explicitly activated. Also we don't want to couple Queue Server deployment and configuration of other services not used by the Queue Server directly, such as Kafka. |
Expected Behavior
Our Kafka servers are secured using SSL and SASL. We wish to supplying the required parameters to the Queueserver's in built Bluesky-Kafka Publisher instance (via the
producer_config
) for connecting to our servers.Current Behavior
Currently there is no way of passing this information through to the Bluesky Kafka Producer instance provided by default within the Queueserver.
Possible Solution
Add a command line argument to
start-re-manager
for passing a path to a Kafka configuration file then reading said config file and passing through to the Kafka-Bluesky Publisher constructor. For example:https://github.com/stmudie/bluesky-queueserver/compare/783b950..895d150
I'm happy for this code to form the basis of a PR (after updating to bring in latest commits from upstream).
Context
Without this configuration option (or an alternative method for configuring the subscribed Kafka publisher/producer) we can't use the Queueserver with our standard Kafka deployments.
The text was updated successfully, but these errors were encountered: