Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to inject plans / objects into the worker #14

Open
tacaswell opened this issue Sep 2, 2020 · 0 comments
Open

ability to inject plans / objects into the worker #14

tacaswell opened this issue Sep 2, 2020 · 0 comments
Labels
server The core API server web client An HTML/JS UI to the API server worker

Comments

@tacaswell
Copy link
Collaborator

If we trust the users they should be able to inject into the server new plans (and objects?) similar to how they do they do now when they are at the beamline. This needs to be done carefully as it is letting the users send us arbitrary Python code. We should consider

  • details of the mechanism (eval/exec, write to disk and import)
  • how to persist user added plans + devices
  • should we bother trying to validate / sanitize / sandbox (S. Dower has publicly said this is a lost cause)
  • if there needs to be any review steps by BL staff before the code is accepted to the system
@tacaswell tacaswell added worker server The core API server web client An HTML/JS UI to the API server labels Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server The core API server web client An HTML/JS UI to the API server worker
Projects
None yet
Development

No branches or pull requests

1 participant