Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality umbrella #1675

Open
65 of 74 tasks
gaearon opened this issue Oct 11, 2023 · 5 comments
Open
65 of 74 tasks

Quality umbrella #1675

gaearon opened this issue Oct 11, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@gaearon
Copy link
Collaborator

gaearon commented Oct 11, 2023

I'll keep track of some things that are bugging me here.

This is an incomplete list, I'll keep adding stuff here.

@gaearon gaearon added the bug Something isn't working label Oct 11, 2023
@gaearon gaearon mentioned this issue Oct 11, 2023
24 tasks
@mozzius
Copy link
Member

mozzius commented Oct 12, 2023

Pressing the notification icon doesn't do the refresh animation properly

For whatever reason, you can't declaratively show the platform refresh animation - hence the fake spinner. Even if you can't use the platform animation, It'd probably look significantly better if you added Reanimated layout animations so that it didn't jump open/closed

Worth noting twitter shows no animation, and threads shows a spinner in the header, top right - I've yet to find an instance where an app opens the pull-to-refresh thing by pressing a different button.

@gaearon
Copy link
Collaborator Author

gaearon commented Oct 12, 2023

Makes sense. Not saying it needs to animate in particular but something feels janky about it. I guess maybe not showing the spinner (like twitter does) may be better.

@mackuba
Copy link

mackuba commented Nov 7, 2023

@gaearon hey, I finally managed to catch the "jumping up and down when scrolling far down a list" effect that I mentioned recently - I saw this while scrolling on my own profile for posts >1 month ago: https://files.mastodon.social/media_attachments/files/111/371/299/920/026/645/original/29aaba275b20302d.mp4 (starts around ~0:20)
Safari 17.1, macOS 12.7.1

I used to see the same thing back in the summer while scrolling the "What's Hot Classic" feed back when it was the "What's Hot" official feed and when it was still possible to scroll a couple of hours back in it.

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 7, 2023

Very interesting, thanks!

@velosol
Copy link

velosol commented Oct 9, 2024

I'm not quite sure where to broach this but I wanted to suggest an enhancement to Lightbox gestures on Android to support "doubletap with swipe"* to mimic pinch to zoom. It's a long-standing and one-handed accessible zoom option that I think would be nice when viewing images.

*: https://www.youtube.com/watch?v=6Y7nPhk18W0 (not my video but shows the gesture)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants