Skip to content

patch_header.go: Fix build issue with older go versions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2022
Merged

patch_header.go: Fix build issue with older go versions #31

merged 1 commit into from
Feb 28, 2022

Conversation

goldsteinn
Copy link
Contributor

No description provided.

bluekeyes
bluekeyes approved these changes Feb 28, 2022
View reviewed changes
Copy link
Owner

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it should be fine to switch back to ioutil for now. Out of curiosity, what version of Go are you using? The io equivalents were introduced in 1.16, which is currently the oldest supported version.

@bluekeyes bluekeyes merged commit 52645c6 into bluekeyes:master Feb 28, 2022
@goldsteinn
Copy link
Contributor Author

Thanks, I think it should be fine to switch back to ioutil for now. Out of curiosity, what version of Go are you using? The io equivalents were introduced in 1.16, which is currently the oldest supported version.

$> go version 
go1.13.8 linux/amd64

Don't really use go much, was really trying to get your patch2pr project working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluekeyes bluekeyes bluekeyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldsteinn @bluekeyes