Skip to content

Add validation for parsed files #12

Open
@bluekeyes

Description

@bluekeyes

If a patch is malformed or a File is created directly, various fields may disagree. Add a validate function that checks for these types of issues so clients (e.g. appliers) can rely on the content of the fields.

Some of the issues to check:

  • IsRename is true/false but OldName and NewName are equal/not equal
  • IsDelete or IsNew is true but there is more than one fragment
  • IsDelete is true but the single fragment has context or addition lines or NewPosition and NewLines are not 0
  • IsNew is true but the single fragment has context or deletion lines or OldPosition and OldLines are not 0
  • IsBinary is true but TextFragments is not empty

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestparsingIssues related to parsing patches

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions