Skip to content

Conversation

@krll-kov
Copy link

Fixed #1956 this issue related to missing MFP on N and KN versions of Windows (European and Korean)

Now plugin uses delayed load mechanism for important dlls and adds error messages to log when trying to set source when this issue is present.

There are no breaking changes in this update

@Gustl22
Copy link
Collaborator

Gustl22 commented Nov 25, 2025

Thank you for contributing. And sorry, always struggling to find time for review.

I wonder if we could just try catch all errors to avoid crashes like done in our linux implementation:

That way all other methods don't need a special handling and the error is propagated to the user.

If want to warn exactly about this specific issue (which is not player or source related -> so global) one could introduce a check on the global channel level on first initialization and throw an error if Media Feature Pack is not installed.

I will have a closer look once our pipeline is working again properly ;D

@krll-kov
Copy link
Author

krll-kov commented Nov 26, 2025

Thank you for contributing. And sorry, always struggling to find time for review.

I wonder if we could just try catch all errors to avoid crashes like done in our linux implementation:

That way all other methods don't need a special handling and the error is propagated to the user.

If want to warn exactly about this specific issue (which is not player or source related -> so global) one could introduce a check on the global channel level on first initialization and throw an error if Media Feature Pack is not installed.

I will have a closer look once our pipeline is working again properly ;D

No, unfortunately, try catch was not possible during tests, app just crashed. Even __try __catch with specific error did not help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows 11 (N/KN) Silent crash of app on start because of absence of MFPlat.DLL

2 participants