feat: add support for async database #1809
Merged
+243
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Sep 26, 2024
| fn basic_async( | ||
| &mut self, | ||
| address: Address, | ||
| ) -> impl Future<Output = Result<Option<AccountInfo>, Self::Error>> + Send; |
There was a problem hiding this comment.
I was not up to date with what is canonical way to express this. I know that async fn is a possibility but after googling it, it seems it is hard to express Send/Sync/static requirements, and this looks like the best approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by AlloyDB, I created
DatabaseAsyncandDatabaseAsyncReftraits that are async versions ofDatabaseandDatabaseRef. They are accompanied byWrapDatabaseAsync, that handles most of the logic.Portal network already uses almost identical implementation: link.
Note: First time contributing to this repo. Let me know if I'm doing something wrong, have to run some tests, etc.