Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4788: Beacon block root in the EVM #525

Closed
Tracked by #527
rakita opened this issue Jun 19, 2023 · 9 comments
Closed
Tracked by #527

EIP-4788: Beacon block root in the EVM #525

rakita opened this issue Jun 19, 2023 · 9 comments
Labels
hf-cancun Cancun hardfork

Comments

@rakita
Copy link
Member

rakita commented Jun 19, 2023

Add new stateful precompile that saved beaconroot

Root should be set before executing transaction.

Precompile should have access to the state.

More info here: https://eips.ethereum.org/EIPS/eip-4788

@rakita rakita added the hf-cancun Cancun hardfork label Jun 19, 2023
@rakita rakita mentioned this issue Jun 19, 2023
5 tasks
@0xJepsen
Copy link
Contributor

0xJepsen commented Aug 3, 2023

I am down to take a crack at this if the 4844 looks good to you!

@rakita
Copy link
Member Author

rakita commented Aug 4, 2023

I am down to take a crack at this if the 4844 looks good to you!

Hey, eip4844 pr doesn't look great, I still need to look at it in detail but I lean on just rewriting it as it seems easier, in mcopy case when I look at it now, that would be a better choice.

For this EIP, eth devs decided to do it in a different way, as in having a system bytecode that is going to be called at the start of the block. You can read about it inside Eth R&D discord testing chat

@0xJepsen
Copy link
Contributor

0xJepsen commented Aug 8, 2023

I am down to take a crack at this if the 4844 looks good to you!

Hey, eip4844 pr doesn't look great, I still need to look at it in detail but I lean on just rewriting it as it seems easier, in mcopy case when I look at it now, that would be a better choice.

For this EIP, eth devs decided to do it in a different way, as in having a system bytecode that is going to be called at the start of the block. You can read about it inside Eth R&D discord testing chat

If you have feedback on 4844, it would be really helpful for me to learn what you would like to be done better, and how to do it. I spent a lot of time studying and working on this, trying to do it correctly. I don't expect it to be perfect right now, but with good feedback I will do it correctly. It is important to me to understand what is not good / incorrect about the current implementation so that i know how to do better.

@rakita
Copy link
Member Author

rakita commented Aug 8, 2023

I am down to take a crack at this if the 4844 looks good to you!

Hey, eip4844 pr doesn't look great, I still need to look at it in detail but I lean on just rewriting it as it seems easier, in mcopy case when I look at it now, that would be a better choice.
For this EIP, eth devs decided to do it in a different way, as in having a system bytecode that is going to be called at the start of the block. You can read about it inside Eth R&D discord testing chat

If you have feedback on 4844, it would be really helpful for me to learn what you would like to be done better, and how to do it. I spent a lot of time studying and working on this, trying to do it correctly. I don't expect it to be perfect right now, but with good feedback I will do it correctly. It is important to me to understand what is not good / incorrect about the current implementation so that i know how to do better.

Gave feedback as it should be good to learn from it, I still intend to rewrite it as in the end I will be left with maintaining it.

@0xJepsen
Copy link
Contributor

0xJepsen commented Aug 9, 2023

Revm is a very important part of the project i work on and the greater ethereum ecosystem. I intend to help where i can to support the project which is why i am here contributing and learning the code base.

@rakita
Copy link
Member Author

rakita commented Sep 7, 2023

@Rjected just to confirm, there is no need to have any changes inside revm for this?

@Rjected
Copy link
Collaborator

Rjected commented Sep 7, 2023

@Rjected just to confirm, there is no need to have any changes inside revm for this?

yes, PR is on reth and does not require EVM changes (see how the block / tx env is set):
paradigmxyz/reth#4457

@gakonst
Copy link
Collaborator

gakonst commented Sep 8, 2023

Given that, should we close this? Pretty nice!

@rakita
Copy link
Member Author

rakita commented Sep 8, 2023

No actions needed

@rakita rakita closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hf-cancun Cancun hardfork
Projects
None yet
Development

No branches or pull requests

4 participants