Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-6780: SELFDESTRUCT only in same transaction #524

Closed
Tracked by #527
rakita opened this issue Jun 19, 2023 · 5 comments · Fixed by #719
Closed
Tracked by #527

EIP-6780: SELFDESTRUCT only in same transaction #524

rakita opened this issue Jun 19, 2023 · 5 comments · Fixed by #719
Labels
hf-cancun Cancun hardfork

Comments

@rakita
Copy link
Member

rakita commented Jun 19, 2023

More info here: https://eips.ethereum.org/EIPS/eip-6780

@rakita rakita added the hf-cancun Cancun hardfork label Jun 19, 2023
@rakita
Copy link
Member Author

rakita commented Jun 19, 2023

Add it after account state: #499

@thedevbirb
Copy link
Contributor

thedevbirb commented Sep 10, 2023

Hi! I tried to take a look at this EIP and issue. I was wondering if I could try to tackle it or if it is 'reserved' (sorry for the lack of a better term) to the more experienced/main contributors of this project. If this is the case it's fine I have no problems with it and I understand.

I'd be happy to work at it with some support here and there, since it is my first EIP I'll try to do. Thanks a lot!

@rakita
Copy link
Member Author

rakita commented Sep 11, 2023

Hi! I tried to take a look at this EIP and issue. I was wondering if I could try to tackle it or if it is 'reserved' (sorry for the lack of a better term) to the more experienced/main contributors of this project. If this is the case it's fine I have no problems with it and I understand.

I'd be happy to work at it with some support here and there, since it is my first EIP I'll try to do. Thanks a lot!

You can try it, this should be a small change. There is already a crated flag inside the Journal that should help with this.

@thedevbirb
Copy link
Contributor

Where can I find the appropriate tests for this EIP? Looking at https://github.com/ethereum/tests I've found something here https://github.com/ethereum/tests/tree/develop/EIPTests/Pyspecs/cancun, however they fail to run with this error: Error: Statetest(SerdeDeserialize(Error("missing field `env`", line: 165, column: 5)))
I don't understand if I should fix something here or if the tests inside such folder are not really compatible with the existing revm code. Thanks for the support!

@rakita
Copy link
Member Author

rakita commented Sep 13, 2023

Where can I find the appropriate tests for this EIP? Looking at https://github.com/ethereum/tests I've found something here https://github.com/ethereum/tests/tree/develop/EIPTests/Pyspecs/cancun, however they fail to run with this error: Error: Statetest(SerdeDeserialize(Error("missing field `env`", line: 165, column: 5))) I don't understand if I should fix something here or if the tests inside such folder are not really compatible with the existing revm code. Thanks for the support!

Not that I know for state tests, they are probably going to be added afterwards. Those jsons are blockchain tests that can be run inside reth: https://github.com/paradigmxyz/reth/tree/main/testing/ef-tests, it seems the usage explanation is here: paradigmxyz/reth#2847

Can you push the PR so I can check it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hf-cancun Cancun hardfork
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants