Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes to 125 and 137 #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixes to 125 and 137 #142

wants to merge 2 commits into from

Conversation

GuyL99
Copy link
Contributor

@GuyL99 GuyL99 commented Oct 18, 2023

Fixes to issues 125 and 137
#125
#137

@GuyL99 GuyL99 requested a review from RazMag October 18, 2023 16:01
@RazMag
Update Cargo.toml
e4f9cc2 
changed deps to use path locally and crates.io when publised
RazMag
RazMag approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@RazMag RazMag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go 👍
we should also add the .swp extension to the .gitignore at some point

@RazMag
Copy link
Collaborator

RazMag commented Oct 19, 2023

we just need to publish each crate separately

GuyL99
GuyL99 commented Oct 22, 2023
View reviewed changes
Copy link
Contributor Author

@GuyL99 GuyL99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be cherrybomb-oas 0.1, we need to update it to 0.2 because I made breaking changes.
We need to start updating the crates.io thingy, because a lot has changed

@DeliciousBounty
Copy link
Collaborator

?? Why this is still open ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazMag RazMag RazMag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuyL99 @RazMag @DeliciousBounty