Sip 35 skinny ether collateral (Synthetixio#385)

SIP 35 EtherCollateral

Author: CLINT

.vscode/settings.json

@@ -4,7 +4,6 @@
 	"solidity.compilerOptimization": 200,
 	"solidity.packageDefaultDependenciesContractsDirectory": "",
 	"solidity.packageDefaultDependenciesDirectory": "node_modules",
-	"eslint.autoFixOnSave": true,
 	"editor.codeActionsOnSave": {
 		"source.fixAll.eslint": true
 	}

contracts/Depot.sol

@@ -409,7 +409,7 @@ contract Depot is SelfDestructible, Pausable {
      * @param guaranteedEtherRate The ether exchange rate which must be honored or the call will revert.
      * @param guaranteedSynthetixRate The synthetix exchange rate which must be honored or the call will revert.
      */
-    function exchangeEtherForSynthetixAtRate(uint guaranteedEtherRate, uint guaranteedSynthetixRate)
+    function exchangeEtherForSNXAtRate(uint guaranteedEtherRate, uint guaranteedSynthetixRate)
         public
         payable
         pricesNotStale
@@ -428,7 +428,7 @@ contract Depot is SelfDestructible, Pausable {
      * @notice Exchange sUSD for SNX
      * @param synthAmount The amount of synths the user wishes to exchange.
      */
-    function exchangeSynthsForSynthetix(uint synthAmount)
+    function exchangeSynthsForSNX(uint synthAmount)
         public
         pricesNotStale
         notPaused
@@ -458,7 +458,7 @@ contract Depot is SelfDestructible, Pausable {
      * @param synthAmount The amount of synths the user wishes to exchange.
      * @param guaranteedRate A rate (synthetix price) the caller wishes to insist upon.
      */
-    function exchangeSynthsForSynthetixAtRate(uint synthAmount, uint guaranteedRate)
+    function exchangeSynthsForSNXAtRate(uint synthAmount, uint guaranteedRate)
         public
         pricesNotStale
         notPaused
@@ -468,7 +468,7 @@ contract Depot is SelfDestructible, Pausable {
     {
         require(guaranteedRate == usdToSnxPrice, "Guaranteed rate would not be received");
 
-        return exchangeSynthsForSynthetix(synthAmount);
+        return exchangeSynthsForSNX(synthAmount);
     }
 
     /**