Skip to content

Conversation

@CascadingRadium
Copy link
Member

@CascadingRadium CascadingRadium commented Nov 6, 2025

@CascadingRadium CascadingRadium changed the title Support GPU-Accelerated Vector Search GPU-Accelerated Vector Search Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GPU acceleration support for vector field indexing and searching. The changes enable users to specify whether GPU should be used for vector operations through a new configuration field.

Key changes:

  • Added GPU boolean field to FieldMapping struct for configuration
  • Extended vector field constructors to accept and store GPU parameter
  • Added GPU() getter method to VectorField for accessing the GPU configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
mapping/field.go Added GPU boolean field to FieldMapping struct with JSON tag
mapping/mapping_vectors.go Updated vector field creation to pass fm.GPU parameter
document/field_vector.go Added gpu field to VectorField struct, updated constructors with GPU parameter, and added GPU() getter method
document/field_vector_base64.go Updated NewVectorBase64Field constructor to accept and forward GPU parameter
Comments suppressed due to low confidence (1)

document/field_vector_base64.go:163

  • VectorBase64Field is missing a GPU() method to match the pattern of delegating VectorField interface methods. Since VectorBase64Field already exposes other VectorField methods like IndexOptimizedFor(), Similarity(), Dims(), and Vector(), it should also expose the GPU() method for API consistency. Add the following method after line 163:\n\ngo\nfunc (n *VectorBase64Field) GPU() bool {\n\treturn n.vectorField.GPU()\n}\n
func (n *VectorBase64Field) IndexOptimizedFor() string {
	return n.vectorField.IndexOptimizedFor()
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants