-
Notifications
You must be signed in to change notification settings - Fork 699
MB-68591: GPU-Accelerated Vector Search #2236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds GPU acceleration support for vector field indexing and searching. The changes enable users to specify whether GPU should be used for vector operations through a new configuration field.
Key changes:
- Added
GPUboolean field toFieldMappingstruct for configuration - Extended vector field constructors to accept and store GPU parameter
- Added
GPU()getter method toVectorFieldfor accessing the GPU configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mapping/field.go | Added GPU boolean field to FieldMapping struct with JSON tag |
| mapping/mapping_vectors.go | Updated vector field creation to pass fm.GPU parameter |
| document/field_vector.go | Added gpu field to VectorField struct, updated constructors with GPU parameter, and added GPU() getter method |
| document/field_vector_base64.go | Updated NewVectorBase64Field constructor to accept and forward GPU parameter |
Comments suppressed due to low confidence (1)
document/field_vector_base64.go:163
- VectorBase64Field is missing a GPU() method to match the pattern of delegating VectorField interface methods. Since VectorBase64Field already exposes other VectorField methods like IndexOptimizedFor(), Similarity(), Dims(), and Vector(), it should also expose the GPU() method for API consistency. Add the following method after line 163:\n\n
go\nfunc (n *VectorBase64Field) GPU() bool {\n\treturn n.vectorField.GPU()\n}\n
func (n *VectorBase64Field) IndexOptimizedFor() string {
return n.vectorField.IndexOptimizedFor()
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gputo indicate whether the vector field must use GPUs for indexing/searching.