Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a document that demonstrates the performance benefits of docvalues #1897

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Added a document that demonstrates the performance benefits of docvalues #1897

merged 4 commits into from
Nov 8, 2023

Conversation

CascadingRadium
Copy link
Contributor

sort_facet.md displays which query configuration utilizes docvalues and, through a test scenario, illustrates the trade-off between the increase in index size and the performance advantage gained in return.

@CascadingRadium CascadingRadium self-assigned this Nov 3, 2023
@CascadingRadium CascadingRadium removed the request for review from steveyen November 3, 2023 10:26
@CascadingRadium CascadingRadium added this to the v2.4.0 milestone Nov 3, 2023
abhinavdangeti
abhinavdangeti requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CascadingRadium Many tables' syntax appears broken. You can view how your markdown renders here - https://github.com/blevesearch/bleve/blob/docValues/docs/sort_facet.md

@CascadingRadium
Copy link
Contributor Author

sorry for that.
The markdown viewer on my computer displayed the content correctly, so I mistakenly pushed it. However, I have resolved the issue now. The two images are encoded in base64, and unfortunately, they are not displayed properly in the GitHub markdown renderer due to a known problem described in this issue: github/markup#270. If you download the file, you will be able to view the images correctly in any markdown viewer, such as MacDown on macOS.

@abhinavdangeti
Copy link
Member

Can you confirm that the renderer is only failing on this pull request but once we merge github should be able to view content properly?

@CascadingRadium
Copy link
Contributor Author

no; github itself does not allow rendering base64-encoded images, whether they are in a PR or are merged. If you clone the repo and view the file in any markdown renderer such as vscode, online, macdown it will show the image properly. this applies only to the two png images of the graphs, all the tables themselves are shown correctly

@CascadingRadium
Copy link
Contributor Author

Done

@abhinavdangeti abhinavdangeti merged commit 907c83e into master Nov 8, 2023
9 checks passed
@abhinavdangeti abhinavdangeti deleted the docValues branch November 8, 2023 17:20
abhinavdangeti added a commit that referenced this pull request Nov 17, 2023
@abhinavdangeti
Merge remote-tracking branch 'origin/master' into unstable
4bce55c 
|\
| * c8e3daf Likith B | #1873: Added timeout option in the Search Handler (#1898)
| * 6dee5e9 Aditi Ahuja | Added missing nil check (#1905)
| * 907c83e Rahul Rampure | Added a document that demonstrates the performance benefits of docvalues (#1897)
abhinavdangeti added a commit that referenced this pull request Nov 17, 2023
@abhinavdangeti
Merge remote-tracking branch 'origin/master' into unstable
c028e47 
|\
| * c8e3daf Likith B | #1873: Added timeout option in the Search Handler (#1898)
| * 6dee5e9 Aditi Ahuja | Added missing nil check (#1905)
| * 907c83e Rahul Rampure | Added a document that demonstrates the performance benefits of docvalues (#1897)
abhinavdangeti added a commit that referenced this pull request Jan 2, 2024
@abhinavdangeti
Merge remote-tracking branch 'origin/master' into unstable
76606df 
|\
| * e26eace Mohd Shaad Khan | MB-60207 fix facets merge (#1946)
| * c8e3daf Likith B | #1873: Added timeout option in the Search Handler (#1898)
| * 6dee5e9 Aditi Ahuja | Added missing nil check (#1905)
| * 907c83e Rahul Rampure | Added a document that demonstrates the performance benefits of docvalues (#1897)
abhinavdangeti added a commit that referenced this pull request Feb 13, 2024
@abhinavdangeti
Merge branch 'origin/master' into '7.6-couchbase' (#1986)
f8af28e 
```
* 5c7445c Abhinav Dangeti | Fix merge conflict
*   a0cb65a Abhinav Dangeti | Merge remote-tracking branch 'origin/master' into 7.6-couchbase
|\
| * 5f1f45a Sergio Vera | Fixed spanish accents normalization (#1957)
| * e26eace Mohd Shaad Khan | MB-60207 fix facets merge (#1946)
| * c8e3daf Likith B | #1873: Added timeout option in the Search Handler (#1898)
| * 6dee5e9 Aditi Ahuja | Added missing nil check (#1905)
| * 907c83e Rahul Rampure | Added a document that demonstrates the performance benefits of docvalues (#1897)
* | 8b9206a Abhi Dangeti | MB-60739: Upgrade go-faiss & zapx/v16 (#1985)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdangeti abhinavdangeti abhinavdangeti approved these changes

@Thejas-bhat Thejas-bhat Awaiting requested review from Thejas-bhat

@metonymic-smokey metonymic-smokey Awaiting requested review from metonymic-smokey

@Likith101 Likith101 Awaiting requested review from Likith101

@moshaad7 moshaad7 Awaiting requested review from moshaad7

Assignees

@CascadingRadium CascadingRadium

Labels
documentation
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@CascadingRadium @abhinavdangeti