Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module for contributed models #380

Open
fredcallaway opened this issue Dec 12, 2016 · 5 comments
Open

Module for contributed models #380

fredcallaway opened this issue Dec 12, 2016 · 5 comments

Comments

@fredcallaway
Copy link

Similarly to how tensorflow has the contrib modules for user-submitted statistical distributions etc., it would be cool to have a module of user-submitted generative models. Such a module would make it easier to build complex models out of complex parts, without implementing the whole thing from scratch.

For example, here is a generic HMM class.

There should probably be an analogous system for other kinds of user-submissions.

@dustinvtran
Copy link
Member

great idea. do you think these should be in the edward core or in an alternative repository? in addition, what level of moderation should we have on contributed models?

@fredcallaway
Copy link
Author

fredcallaway commented Dec 13, 2016

Good questions. Ideally the module would be included in the standard package to encourage its use. However, if we go this route, we'll want to have fairly strict moderation to (1) maintain the quality of the codebase and (2) allow users to use the tools without verifying their correctness. At the minimum, all new functionality should include test cases.

Perhaps a middle ground can be found. Keep a list of "contributions-in-progress" which allows adventurous users to see what others are up to. But only accept a pull request when the contribution is well-tested and well-organized.

Submodules might be a good tool to utilize here.

@dustinvtran
Copy link
Member

the middleground makes sense to me. to some extent tf.contrib solves this issue by generally only allowing new submodules to be created by googlers. making it more rigorous seems necessary if it is to be in edward itself, while we can still refer to in-progress work.

@rw
Copy link
Contributor

rw commented Dec 14, 2016

How does this relate to the proposed Probability Zoo mentioned in the Edward paper?

@dustinvtran
Copy link
Member

the probability zoo is a user-submitted repo for pre-trained probabilistic models, with short scripts on how to use them. i guess the module here would also be user-submitted but be building blocks for easily specifying complex models.

@dustinvtran dustinvtran mentioned this issue Feb 15, 2017
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants