Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "filter_kwargs" on "create_engine" never returns matches #631

Open
joebeeson opened this issue Jan 15, 2021 · 0 comments
Open

Using "filter_kwargs" on "create_engine" never returns matches #631

joebeeson opened this issue Jan 15, 2021 · 0 comments

Comments

@joebeeson
Copy link

In backends.sql:resource.sql function, utils.filter_kwargs always filters all keywords when creating the engine since create_engine's signature doesn't have any keyword arguments.

odo/odo/backends/sql.py

Lines 633 to 640 in 9fce669

@resource.register(r'(.*sql.*|oracle|redshift)(\+\w+)?://.+')
def resource_sql(uri, *args, **kwargs):
engine = create_engine(
uri,
# roundtrip through a frozenset of tuples so we can cache the dict
connect_args=kwargs.pop('connect_args', {}),
**filter_kwargs(sa.create_engine, kwargs)
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant