Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key sticking issue until I upload firmware #17

Open
joefiorini opened this issue Nov 16, 2017 · 1 comment
Open

Key sticking issue until I upload firmware #17

joefiorini opened this issue Nov 16, 2017 · 1 comment
Labels

Comments

@joefiorini
Copy link
Collaborator

I'm on the latest master firmware (commit fd05771) on my Diverge II. I've noticed that any time I reboot my computer or unplug/plug in the keyboard's USB, the master side starts sticking. By that I mean I have to hit every key four or five times before it actually registers. I can work around the issue by uploading the latest firmware again. I actually started noticing this issue when I updated to the commit that contained the debouncing code. Any thoughts on what might be happening here? Any other detail I can provide?

@blahlicus
Copy link
Owner

Hmm, that's weird, the debounce would hang and cause a "stick" like situation if the slave side is not communicating properly, have you updated the firmware on both the slave and the master?

I can't replicate this with #fd05771 on both master and slave of a D3 on Win10 USB 2.0 and 3.0 with refresh delay set at 1, I also can't replicate this with #fd05771 master + 2.3.1 slave. My D2 is currently on loan to a friend, but I'll also test it out once I get it back.

Also what is your refresh delay setting? Does pressing and holding a key for a while completely eliminate the skipped key? (perhaps the key was not held down long enough for the debounce prevention to wear off?)

The current apparent suspects for me would be either a communication issue in between the sides or over-zealous debounce prevention due to high refresh delay value. Regardless, I'll do a rework on the debounce prevention, currently, it works by requiring a key to be held down for x milliseconds before triggering a keydown event, perhaps I'll experiment on a cooldown based debounce prevention algorithm instead.

@blahlicus blahlicus added this to the 3.0 release milestone Apr 10, 2018
@blahlicus blahlicus added the bug label Apr 10, 2018
@blahlicus blahlicus removed this from the 3.0 release milestone Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants