This repository was archived by the owner on May 10, 2021. It is now read-only.
Changed elo to ranking #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now shows player division/league
The light should now turn red successfully when you turn off the game It also now sends an error message when privileges are wrong
Accidentally left this part out
|
I created all the missing icons for the characters up to bard, would love to add them to your branch. |
|
If you want to do that, you need to submit a pull request to https://github.com/SebastienGllmt/LoLNotes |
|
Ok I will spend some effort in learning how to do that through Github. Latest patch seems to have broken the tool. NM it still works just reinstalled the cert, and restarted it all. I will work on getting the icons and text control file submitted. Update: I hate using this site for this type of work, I ended up creating a new text file I dont want and adding the icons seems to be more effort then it is worth. I could do this in Perforce in 15 seconds. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elo hasn't been visible for a long time, so it shows ranking for users now.
It also fixes that it wasn't able to pull summoner levels
I also got rid of the links to the website which doesn't exist anymore
Lastly, I got rid of a certificate that was no longer used.