-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Notion Publisher #223
base: main
Are you sure you want to change the base?
feat: Notion Publisher #223
Conversation
nice start! We have some changes coming in the next couple of days, which would require adjustments in your draft. for the data source -- I think we can consolidate it under the existing |
Sounds good! I'll hold off changes for a bit and keep dialing in the upstream markdown to blocks converter until that breaking change comes out. |
@brittonhayes just a ping that the recent big refactoring was merged in! |
Awesome! Thanks for the ping @traut I'll set aside some time to checkout the new changes and get this feature all wrapped up ✔️ |
Hey again @traut! I got all the conflicts sorted out. Currently at a spot where I'm unsure how to test the publisher since it requires installing the plugin from the registry but the plugin is only present locally. Also thinking it would probably make sense for this publisher to support some of the builtin content providers like title, codeblock, list, text, blockquote etc; however the built-in content providers are not exported from the |
@britton-from-notion, I'm sorry for the huge delay here. We're working on a heavy refactoring that changes how we handle formatting/publishing in Fabric (see #239). The goal is to detach the internal data model from Markdown, allowing us to support more formats (better HTML and PDF) and more publishers (allowing publisher-specific formatting suitable for Notion, for example). We hope to get the code in in the next week, and I'll be happy to help adjust your code to it! |
Changes
Notes
This is a really rough first pass at the Notion publisher. I have not run this, it's really just the general layout of the code. Will make some more iterations of this but putting up the draft PR to share the work as I go and take any feedback!
fixes #221