Merge pull request flutter#1 from ened/webview_assets_patch

Webview assets patch

Author: shaqian

.ci/Dockerfile

@@ -5,4 +5,7 @@ RUN yes | sdkmanager \
     "platforms;android-27" \
     "build-tools;27.0.3" \
     "extras;google;m2repository" \
-    "extras;android;m2repository"
+    "extras;android;m2repository" \
+    "system-images;android-21;default;armeabi-v7a"
+
+RUN yes | sdkmanager --licenses

.cirrus.yml

@@ -2,8 +2,8 @@ task:
   use_compute_credits: $CIRRUS_USER_COLLABORATOR == 'true' && $CIRRUS_PR == ''
   container:
     dockerfile: .ci/Dockerfile
-    cpu: 4
-    memory: 8G
+    cpu: 8
+    memory: 16G
   upgrade_script:
     - flutter channel master
     - flutter upgrade
@@ -22,11 +22,17 @@ task:
       test_script: ./script/incremental_build.sh test
     - name: analyze
       script: ./script/incremental_build.sh analyze
-    - name: build-apks+java-test
+    - name: build-apks+java-test+drive-examples
       env:
         matrix:
           PLUGIN_SHARDING: "--shardIndex 0 --shardCount 2"
           PLUGIN_SHARDING: "--shardIndex 1 --shardCount 2"
+        MAPS_API_KEY: ENCRYPTED[596a9f6bca436694625ac50851dc5da6b4d34cba8025f7db5bc9465142e8cd44e15f69e3507787753accebfc4910d550]
+      create_device_script:
+        echo no | avdmanager -v create avd -n test -k "system-images;android-21;default;armeabi-v7a"
+      start_emulator_background_script:
+      - $ANDROID_HOME/emulator/emulator -avd test -no-audio -no-window
+      wait_for_emulator_script: adb wait-for-device
       script:
         # Unsetting CIRRUS_CHANGE_MESSAGE and CIRRUS_COMMIT_MESSAGE as they
         # might include non-ASCII characters which makes Gradle crash.
@@ -40,19 +46,25 @@ task:
         - export CIRRUS_COMMIT_MESSAGE=""
         - ./script/incremental_build.sh build-examples --apk
         - ./script/incremental_build.sh java-test  # must come after apk build
+        # TODO(jackson): Re-enable once Android emulators support Firebase
+        # https://github.com/flutter/flutter/issues/29571
+        # - ./script/incremental_build.sh drive-examples
         - export CIRRUS_CHANGE_MESSAGE=`cat /tmp/cirrus_change_message.txt`
         - export CIRRUS_COMMIT_MESSAGE=`cat /tmp/cirrus_commit_message.txt`
 
 task:
   use_compute_credits: $CIRRUS_USER_COLLABORATOR == 'true'
-  name: build-ipas
+  name: build-ipas+drive-examples
   osx_instance:
     image: mojave-xcode-10.1
   env:
     PATH: $PATH:/usr/local/bin
     matrix:
-      PLUGIN_SHARDING: "--shardIndex 0 --shardCount 2"
-      PLUGIN_SHARDING: "--shardIndex 1 --shardCount 2"
+      PLUGIN_SHARDING: "--shardIndex 0 --shardCount 4"
+      PLUGIN_SHARDING: "--shardIndex 1 --shardCount 4"
+      PLUGIN_SHARDING: "--shardIndex 2 --shardCount 4"
+      PLUGIN_SHARDING: "--shardIndex 3 --shardCount 4"
+    SIMCTL_CHILD_MAPS_API_KEY: ENCRYPTED[596a9f6bca436694625ac50851dc5da6b4d34cba8025f7db5bc9465142e8cd44e15f69e3507787753accebfc4910d550]
   setup_script:
     - brew update
     - brew install libimobiledevice
@@ -64,6 +76,8 @@ task:
     - export PATH=`pwd`/flutter/bin:`pwd`/flutter/bin/cache/dart-sdk/bin:$PATH
     - flutter doctor
     - pub global activate flutter_plugin_tools
+    - xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-X com.apple.CoreSimulator.SimRuntime.iOS-12-1 | xargs xcrun simctl boot
   build_script:
     - export PATH=`pwd`/flutter/bin:`pwd`/flutter/bin/cache/dart-sdk/bin:$PATH
     - ./script/incremental_build.sh build-examples --ipa
+    - ./script/incremental_build.sh drive-examples

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,37 @@
+## Description
+
+*Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.*
+
+## Related Issues
+
+*Replace this paragraph with a list of issues related to this PR from the [issue database](https://github.com/flutter/flutter/issues). Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.*
+
+## Checklist
+
+Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
+
+- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
+- [ ] My PR includes unit or integration tests for *all* changed/updated/fixed behaviors (See [Contributor Guide]).
+- [ ] All existing and new tests are passing.
+- [ ] I updated/added relevant documentation (doc comments with `///`).
+- [ ] The analyzer (`flutter analyze`) does not report any problems on my PR.
+- [ ] I read and followed the [Flutter Style Guide].
+- [ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
+- [ ] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
+- [ ] I updated CHANGELOG.md to add a description of the change.
+- [ ] I signed the [CLA].
+- [ ] I am willing to follow-up on review comments in a timely manner.
+
+## Breaking Change
+
+Does your PR require plugin users to manually update their apps to accommodate your change?
+
+- [ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
+- [ ] No, this is *not* a breaking change.
+
+<!-- Links -->
+[issue database]: https://github.com/flutter/flutter/issues
+[Contributor Guide]: https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md
+[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
+[pub versioning philosophy]: https://www.dartlang.org/tools/pub/versioning
+[CLA]: https://cla.developers.google.com/

.opensource/project.json

@@ -12,6 +12,7 @@
     "packages/firebase_analytics/README.md": "Analytics",
     "packages/firebase_auth/README.md": "Authentication",
     "packages/firebase_core/README.md": "Core",
+    "packages/firebase_crashlytics/README.md": "Crashlytics",
     "packages/firebase_database/README.md": "Realtime Database",
     "packages/firebase_dynamic_links/README.md": "Dynamic Links",
     "packages/firebase_messaging/README.md": "Cloud Messaging",

AUTHORS

@@ -22,4 +22,15 @@ Thomas Danner <thmsdnnr@gmail.com>
 Diego Velásquez <diego.velasquez.lopez@gmail.com>
 Hajime Nakamura <nkmrhj@gmail.com>
 Tuyển Vũ Xuân <netsoft1985@gmail.com>
+Miguel Ruivo <miguel@miguelruivo.com>
 Sarthak Verma <sarthak@artiosys.com>
+Mike Diarmid <mike@invertase.io>
+Invertase <oss@invertase.io>
+Elliot Hesp <elliot@invertase.io>
+Vince Varga <vince.varga@smaho.com>
+Aawaz Gyawali <awazgyawali@gmail.com>
+EUI Limited <ian.evans3@admiralgroup.co.uk>
+Katarina Sheremet <katarina@sheremet.ch>
+Thomas Stockx <thomas@stockxit.com>
+Sarbagya Dhaubanjar <sarbagyastha@gmail.com>
+Ozkan Eksi <ozeksi@gmail.com>

CODEOWNERS

@@ -4,20 +4,29 @@
 # These names are just suggestions. It is fine to have your changes
 # reviewed by someone else.
 
+packages/android_alarm_manager/* @bkonyi
+packages/camera/* @bparrishMines @mklim
 packages/cloud_firestore/* @collinjackson @kroikie
+packages/cloud_functions/* @collinjackson @kroikie
+packages/connectivity/* @cyanglaz
+packages/firebase_admob/* @amirh @bparrishMines
+packages/firebase_analytics/* @collinjackson @kroikie
 packages/firebase_auth/* @collinjackson @kroikie
+packages/firebase_core/* @collinjackson @kroikie
+packages/firebase_crashlytics/* @kroikie @collinjackson
+packages/firebase_database/* @collinjackson @kroikie
+packages/firebase_dynamic_links/* @bparrishMines
 packages/firebase_messaging/* @collinjackson @kroikie
-packages/camera/* @bparrishMines @mklim
-packages/firebase_admob/* @amirh
 packages/firebase_ml_vision/* @bparrishMines
-packages/image_picker/* @cyanglaz
-packages/android_alarm_manager/* @bkonyi
-packages/google_maps_flutter/* @amirh
-packages/google_sign_in/* @cyanglaz @mehmetf
-packages/in_app_purchase/* @mklim
-packages/firebase_database/* @collinjackson @kroikie
+packages/firebase_performance/* @bparrishMines @collinjackson
+packages/firebase_remote_config/* @collinjackson @kroikie
 packages/firebase_storage/* @collinjackson @kroikie
+packages/google_maps_flutter/* @amirh @iskakaushik
+packages/google_sign_in/* @cyanglaz @mehmetf
+packages/image_picker/* @cyanglaz
+packages/in_app_purchase/* @mklim @cyanglaz
 packages/package_info/* @cyanglaz
-packages/firebase_analytics/* @collinjackson @kroikie
-packages/connectivity/* @cyanglaz
-packages/webview_flutter/* @amirh
+packages/path_provider/* @collinjackson
+packages/shared_preferences/* @collinjackson
+packages/video_player/* @iskakaushik @cyanglaz
+packages/webview_flutter/* @amirh @iskakaushik

CONTRIBUTING.md

@@ -1,7 +1,7 @@
-Contributing to Flutter
-=======================
+Contributing to Flutter Plugins
+===============================
 
-[![Build Status](https://travis-ci.org/flutter/plugins.svg)](https://travis-ci.org/flutter/plugins)
+[![Build Status](https://api.cirrus-ci.com/github/flutter/plugins.svg)](https://cirrus-ci.com/github/flutter/plugins/master)
 
 _See also: [Flutter's code of conduct](https://flutter.io/design-principles/#code-of-conduct)_
 
@@ -40,6 +40,24 @@ USB and debugging enabled on that device.
  * `cd packages/battery/example`
  * `flutter run`
 
+Running the tests
+-----------------
+
+Flutter plugins have both unit tests of their Dart API and integration tests that run on a virtual or actual device.
+
+To run the unit tests:
+
+```
+flutter test test/<name_of_plugin>_test.dart
+```
+
+To run the integration tests:
+
+```
+cd example
+flutter drive test/<name_of_plugin>.dart
+```
+
 Contributing code
 -----------------
 
@@ -74,19 +92,16 @@ To send us a pull request:
 
 Please make sure all your checkins have detailed commit messages explaining the patch.
 
-Once you've gotten an LGTM from a project maintainer and once your PR has received
-the green light from all our automated testing (Travis, AppVeyor, etc), submit your
-changes to the `master` branch using one of the following methods:
+Plugins tests are run automatically on contributions using Cirrus CI. However, due to
+cost constraints, pull requests from non-committers may not run all the tests
+automatically.
 
-* Wait for one of the project maintainers to submit it for you.
-* Click the green "Merge pull request" button on the GitHub UI of your pull
-  request (requires commit access).
+Once you've gotten an LGTM from a project maintainer and once your PR has received
+the green light from all our automated testing, wait for one the package maintainers
+to merge the pull request and `pub submit` any affected packages.
 
 You must complete the
 [Contributor License Agreement](https://cla.developers.google.com/clas).
 You can do this online, and it only takes a minute.
 If you've never submitted code before, you must add your (or your
 organization's) name and contact info to the [AUTHORS](AUTHORS) file.
-
-We grant commit access to people who have gained our trust and demonstrated
-a commitment to Flutter.

FlutterFire.md

@@ -20,6 +20,7 @@ The plugins are still under development, and some APIs might not be available ye
 | [firebase_analytics][analytics_pub] | ![pub package][analytics_badge] | [Firebase Analytics][analytics_product] | [`packages/firebase_analytics`][analytics_code] |
 | [firebase_auth][auth_pub] | ![pub package][auth_badge] | [Firebase Authentication][auth_product] | [`packages/firebase_auth`][auth_code] |
 | [firebase_core][core_pub] | ![pub package][core_badge] | [Firebase Core][core_product] | [`packages/firebase_core`][core_code] |
+| [firebase_crashlytics][crash_pub] | ![pub package][crash_badge] | [Firebase Crashlytics][crash_product] | [`packages/firebase_crashlytics`][crash_code] |
 | [firebase_database][database_pub] | ![pub package][database_badge] | [Firebase Realtime Database][database_product] | [`packages/firebase_database`][database_code] |
 | [firebase_dynamic_links][dynamic_links_pub] | ![pub package][dynamic_links_badge] | [Firebase Dynamic Links][dynamic_links_product] | [`packages/firebase_dynamic_links`][dynamic_links_code] |
 | [firebase_messaging][messaging_pub] | ![pub package][messaging_badge] | [Firebase Cloud Messaging][messaging_product] | [`packages/firebase_messaging`][messaging_code] |
@@ -48,6 +49,11 @@ The plugins are still under development, and some APIs might not be available ye
 [core_code]: https://github.com/flutter/plugins/tree/master/packages/firebase_core
 [core_badge]: https://img.shields.io/pub/v/firebase_core.svg
 
+[crash_pub]: https://pub.dartlang.org/packages/firebase_crashlytics
+[crash_product]: https://firebase.google.com/products/crashlytics/
+[crash_code]: https://github.com/flutter/plugins/tree/master/packages/firebase_crashlytics
+[crash_badge]: https://img.shields.io/pub/v/firebase_crashlytics.svg
+
 [database_pub]: https://pub.dartlang.org/packages/firebase_database
 [database_product]: https://firebase.google.com/products/database/
 [database_code]: https://github.com/flutter/plugins/tree/master/packages/firebase_database

README.md

@@ -65,6 +65,7 @@ These are the available plugins in this repository.
 | [firebase_analytics](./packages/firebase_analytics/) | [![pub package](https://img.shields.io/pub/v/firebase_analytics.svg)](https://pub.dartlang.org/packages/firebase_analytics) |
 | [firebase_auth](./packages/firebase_auth/) | [![pub package](https://img.shields.io/pub/v/firebase_auth.svg)](https://pub.dartlang.org/packages/firebase_auth) |
 | [firebase_core](./packages/firebase_core/) | [![pub package](https://img.shields.io/pub/v/firebase_core.svg)](https://pub.dartlang.org/packages/firebase_core) |
+| [firebase_crashlytics](./packages/firebase_crashlytics/) | [![pub package](https://img.shields.io/pub/v/firebase_crashlytics.svg)](https://pub.dartlang.org/packages/firebase_crashlytics) |
 | [firebase_database](./packages/firebase_database/) | [![pub package](https://img.shields.io/pub/v/firebase_database.svg)](https://pub.dartlang.org/packages/firebase_database) |
 | [firebase_dynamic_links](./packages/firebase_dynamic_links/) | [![pub package](https://img.shields.io/pub/v/firebase_dynamic_links.svg)](https://pub.dartlang.org/packages/firebase_dynamic_links) |
 | [firebase_messaging](./packages/firebase_messaging/) | [![pub package](https://img.shields.io/pub/v/firebase_messaging.svg)](https://pub.dartlang.org/packages/firebase_messaging) |

packages/android_alarm_manager/CHANGELOG.md

@@ -1,3 +1,24 @@
+## 0.4.1+6
+
+* Bump the minimum Flutter version to 1.2.0.
+* Add template type parameter to `invokeMethod` calls.
+
+## 0.4.1+5
+
+* Update AlarmService to throw a `PluginRegistrantException` if
+  `AlarmService.setPluginRegistrant` has not been called to set a
+  PluginRegistrantCallback. This improves the error message seen when the
+  `AlarmService.setPluginRegistrant` call is omitted.
+
+## 0.4.1+4
+
+* Updated example to remove dependency on Firebase.
+
+## 0.4.1+3
+
+* Update README.md to include instructions for setting the WAKE_LOCK permission.
+* Updated example application to use the WAKE_LOCK permission.
+
 ## 0.4.1+2
 
 * Include a missing API dependency.