unit test add for extract lowest version method

Author: zahidblackduck

detectable/src/main/java/com/blackduck/integration/detectable/detectables/npm/packagejson/PackageJsonExtractor.java

@@ -85,7 +85,7 @@ private Dependency entryToDependency(String key, String value) {
         return new Dependency(externalId);
     }
 
-    private String extractLowestVersion(String value) {
+    public String extractLowestVersion(String value) {
         SemVerComparator semVerComparator = new SemVerComparator();
 
         // Split the value into parts by spaces, "||", or "-".
@@ -96,7 +96,7 @@ private String extractLowestVersion(String value) {
             // Remove npm version selection characters that the KB won't match on
             .map(part -> part.replaceAll("[>=<~^]", ""))
             // Filter out parts that don't match the version pattern
-            .filter(part -> isProbableVersion(part))
+            .filter(this::isProbableVersion)
             // Use compareSemVerVersions method to find smallest version in each value
             .min(semVerComparator)
             // If no part matches the version pattern, return the original value.

detectable/src/test/java/com/blackduck/integration/detectable/detectables/npm/packagejson/unit/PackageJsonExtractorTest.java

@@ -109,6 +109,27 @@ void extractWithNonNumericalCharacters() {
         graphAssert.hasRootSize(7);
     }
 
+    @Test
+    void shouldExtractLowestSemVerCorrectly() {
+        PackageJsonExtractor extractor = createExtractor();
+
+        assertEquals("1.0.0", extractor.extractLowestVersion("1.0.0 - 2.9999.9999"));
+        assertEquals("1.0.2", extractor.extractLowestVersion( ">=1.0.2 <2.1.2"));
+        assertEquals("1.0.0", extractor.extractLowestVersion("<1.0.0 || >=2.3.1 <2.4.5 || >=2.5.2 <3.0.0"));
+        assertEquals("1.2.0", extractor.extractLowestVersion("~1.2.0"));
+        assertEquals("3.3.0", extractor.extractLowestVersion("3.3.x"));
+        assertEquals("1.0.0", extractor.extractLowestVersion("1.0.0-SNAPSHOT"));
+        assertEquals("1.2.3", extractor.extractLowestVersion( "^1.2.3"));
+        assertEquals("1.2.3", extractor.extractLowestVersion("1.2.3-alpha"));
+        assertEquals("17.0.0", extractor.extractLowestVersion( "17.0.0-1551262265873"));
+        assertEquals("3.2.0", extractor.extractLowestVersion("^3.2.0 || 4.0.1"));
+        assertEquals("1.2.0", extractor.extractLowestVersion("~1.2.x"));
+        assertEquals("1.2.3", extractor.extractLowestVersion("1.2.3-beta.2"));
+        assertEquals("5.0.0", extractor.extractLowestVersion( "5.0.0-alpha+build.1"));
+        assertEquals("3.0.0", extractor.extractLowestVersion("3.0.0-abc123"));
+        assertEquals("10.0.0", extractor.extractLowestVersion("10.0.0-0000000000123"));
+    }
+
     private CombinedPackageJson createPackageJson() {
         CombinedPackageJson combinedPackageJson = new CombinedPackageJson();