feat!: redesign parameters to specify APIM instance for import-from-apim command #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackchoey
commented
May 21, 2024
| @@ -17,8 +17,14 @@ | |||
| class ImportFromApim(AAZCommand): | |||
| """Imports APIs from an Azure API Management service instance. | |||
|
|
|||
| :example: Import From APIM | |||
| az apic service import-from-apim -g api-center-test --service-name contosoeuap --source-resource-ids '/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/servicegroup/providers/Microsoft.ApiManagement/service/contoso/apis/contosoapi' | |||
| :example: Import all APIs from APIM in same resource group | |||
There was a problem hiding this comment.
@juliajuju93 can you help review the examples here? Please leave comments or approve the PR if they look good to you.
adashen
approved these changes
May 22, 2024
blackchoey
added a commit
that referenced
this pull request
Jul 17, 2024
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * test: add test cases for commands (#40) * fix: error when register API with long description spec (#41) * test: add test cases for optional parameters (#42) * feat!: remove file name param (#43) * fix: error not thrown when import spec with >3MB file (#44) * feat!: remove state param for deployment commands (#46) * fix: API title created by register command is not same with provided spec (#47) * feat!: redesign parameters to specify APIM instance for import-from-apim command (#45) * test: clean up legacy test cases (#48) * test: add test cases for command examples (#49) * docs: update help message per feedback (#50) * build: bump version to 1.0.0 and add changelog (#51) * fix: some parameters should be required in import-specification and deployment command (#53) * feat!: rename parameter names to align with other Azure CLI command experience (#52) * test: enable test for import-from-apim (#54) * test: fix show service test case (#55) * docs: update changelog for 1.0.0 (#56) * Update HISTORY.rst - jukasper updated changelog * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * docs: update readme for apic-extension (#57) * fix: cannot run create command against existing resource (#58) * fix: cannot run create command against existing resource * style: fix style * build: remove cicd pipeline (#59) * build: resolve review comments (#60) --------- Co-authored-by: Julia Kasper <42241691+juliajuju93@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--apim-subscription,--apim-resource-group,--apim-name,--apim-apisparameters toaz apic service import-from-apimcommand to help users better specify the APIM instance.--source-resource-idsparameter is removed from the command.