Skip to content

Fix PoolConstraints infinite wait when the max value Is zero #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

powerumc
Copy link

@powerumc powerumc commented Feb 9, 2025

I've created issue #397 and am submitting a PR that adds effective tests.
In summary, if you set the pool size using PoolConstraints::new(0, 0), the connection will wait indefinitely.

I've added two tests to verify this behavior at runtime and at compile time:

  • PoolConstraints::new(0, 0);
  • PoolConstraints::new_const::<0, 0>();

Please review. Thank you.

@powerumc
Copy link
Author

@blackbeam Hi there 👋

I hope you’re doing well. I just wanted to kindly follow up on this PR and would greatly appreciate your review whenever you have a moment. Please let me know if there’s anything I can clarify or improve. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant