give Pointer::into_parts a more scary name and offer a safer alternative

RalfJung · RalfJung · commit 0bd5a21843ee · 2025-06-29T00:16:19.000+02:00
diff --git a/src/constant.rs b/src/constant.rs
@@ -133,7 +133,7 @@ pub(crate) fn codegen_const_value<'tcx>(
                 }
             }
             Scalar::Ptr(ptr, _size) => {
-                let (prov, offset) = ptr.into_parts(); // we know the `offset` is relative
+                let (prov, offset) = ptr.prov_and_relative_offset();
                 let alloc_id = prov.alloc_id();
                 let base_addr = match fx.tcx.global_alloc(alloc_id) {
                     GlobalAlloc::Memory(alloc) => {

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ pub(crate) fn codegen_const_value<'tcx>(`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`	`Scalar::Ptr(ptr, _size) => {`
`136`		- let (prov, offset) = ptr.into_parts(); // we know the `offset` is relative
	`136`	`+ let (prov, offset) = ptr.prov_and_relative_offset();`
`137`	`137`	`let alloc_id = prov.alloc_id();`
`138`	`138`	`let base_addr = match fx.tcx.global_alloc(alloc_id) {`
`139`	`139`	`GlobalAlloc::Memory(alloc) => {`