Skip to content

Commit 465b650

Browse files
committed
Merge pull request #23 from chrmoritz/master
Updated regions and video/audio codec support check. Thanks to chrmoritz!
2 parents a9504ca + 08f233a commit 465b650

File tree

3 files changed

+24
-8
lines changed

3 files changed

+24
-8
lines changed

src/main/java/de/bitzeche/video/transcoding/zencoder/enums/ZencoderRegion.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,18 @@
1717
package de.bitzeche.video.transcoding.zencoder.enums;
1818

1919
public enum ZencoderRegion {
20-
EUROPE, US, ASIA;
20+
US("us"), EUROPE("europe"), ASIA("asia"), SA("sa"), AUSTRALIA("australia"),
21+
VIRGINIA("us-n-virginia"), OREGON("us-oregon"), CALIFORNIA("us-n-california"),
22+
DUBLIN("eu-dublin"), SINGAPORE("asia-singapore"), TOKYO("asia-tokyo"),
23+
SAOPAULO("sa-saopaulo"), SYDNEY("australia-sydney");
24+
25+
private final String regionCode;
26+
27+
private ZencoderRegion(String code) {
28+
this.regionCode = code;
29+
}
30+
31+
public String getRegionCode() {
32+
return regionCode;
33+
}
2134
}

src/main/java/de/bitzeche/video/transcoding/zencoder/job/ZencoderJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public Document createXML() throws ParserConfigurationException {
9191
// region
9292
if (this.zencoderRegion != null) {
9393
Node region = document.createElement("region");
94-
region.setTextContent(this.zencoderRegion.name().toLowerCase());
94+
region.setTextContent(this.zencoderRegion.getRegionCode());
9595
root.appendChild(region);
9696
}
9797

src/main/java/de/bitzeche/video/transcoding/zencoder/job/ZencoderOutput.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -456,17 +456,20 @@ public void setBufferSize(int size) {
456456
}
457457

458458
public void setAudioCodec(ZencoderAudioCodec codec) {
459-
if ((videoCodec.equals(ZencoderVideoCodec.h264) || videoCodec
460-
.equals(ZencoderVideoCodec.vp6))
461-
&& !(codec.equals(ZencoderAudioCodec.mp3) || codec
462-
.equals(ZencoderAudioCodec.aac))) {
459+
if ((videoCodec.equals(ZencoderVideoCodec.h264) || videoCodec.equals(ZencoderVideoCodec.vp6)
460+
|| videoCodec.equals(ZencoderVideoCodec.mpeg4))
461+
&& !(codec.equals(ZencoderAudioCodec.mp3) || codec.equals(ZencoderAudioCodec.aac))) {
463462
throw new IllegalArgumentException(
464-
"H264 and VP6 only support MP3 or AAC");
463+
"H264, MPEG-4 and VP6 only support MP3 or AAC");
465464
} else if ((videoCodec.equals(ZencoderVideoCodec.theora) || videoCodec
466465
.equals(ZencoderVideoCodec.vp8))
467466
&& !codec.equals(ZencoderAudioCodec.vorbis)) {
468467
throw new IllegalArgumentException(
469-
"H264 and VP8 only support MP3 or AAC");
468+
"Theora and VP8 only support Vorbis");
469+
} else if (videoCodec.equals(ZencoderVideoCodec.wmv)
470+
&& !(codec.equals(ZencoderAudioCodec.wma) || codec.equals(ZencoderAudioCodec.mp3))) {
471+
throw new IllegalArgumentException(
472+
"WMV only support WMA and MP3");
470473
}
471474
this.audioCodec = codec;
472475
}

0 commit comments

Comments
 (0)