Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Firefox Nightly to fido2_privileged_allow_list.json. #3315

Open
1 task
segln mannequin opened this issue Jun 10, 2024 · 14 comments
Open
1 task

Please add Firefox Nightly to fido2_privileged_allow_list.json. #3315

segln mannequin opened this issue Jun 10, 2024 · 14 comments
Labels
bug Something isn't working

Comments

@segln
Copy link
Mannequin

segln mannequin commented Jun 10, 2024

Steps To Reproduce

  1. Navigate to a website that supports passkey.
  2. The passkey list is shown.
  3. Select a passkey.

Expected Result

Bitwarden shows (fingerprint)authentication form and continues to website.

Actual Result

An error occurred. "Passkey operation failed because browser is not privileged"

Screenshots or Videos

No response

Additional Context

There is no Firefox nightly(org.mozilla.fenix) in fido2_privileged_allow_list.json.

Operating System

Android

Operating System Version

14

Device

Samsung Galaxy S24+

Build Version

2024.5.1 (10574)

Beta

  • Using a pre-release version of the application.
@segln segln mannequin added the bug Something isn't working label Jun 10, 2024
@daniellbw
Copy link
Mannequin

daniellbw mannequin commented Jun 14, 2024

Hi there,

Thank you for your report! This has been flagged to our engineering team.

@vvolkgang vvolkgang transferred this issue from another repository Jun 19, 2024
@vvolkgang vvolkgang transferred this issue from another repository Jun 19, 2024
@RadNotRed
Copy link

Can Iceraven also be added? Firefox fork for Android https://github.com/fork-maintainers/iceraven-browser

@yetdragon
Copy link

Fennec (F-Droid's fork of Firefox) also seems to be not in the list.

@M3gaFr3ak
Copy link

Mull also isn't privileged.

@bb010g
Copy link

bb010g commented Aug 31, 2024

How are browser developers on Android expected to work around this when testing passkey support with Bitwarden?

@bb010g
Copy link

bb010g commented Aug 31, 2024

This issue was introduced by:

Could we be informed of the reasoning behind PM-7658 and why it's beneficial and/or necessary for Bitwarden to implement its own verification on top of Android's existing passkey flow?

@KiARC
Copy link

KiARC commented Sep 1, 2024

Seconding bb010g: This seems like a poor design choice. What benefit is there to locking out uncommon/nonstandard browsers from passkey usage? Surely it should be the user's responsibility to avoid unsafe browsers, not Bitwarden's to refuse to interoperate with them.

If there really is a need for this, perhaps a setting could be added by which users can whitelist specific apps (such as Firefox Nightly) to be considered privileged, so that at the very least it isn't something that requires a PR to fix for each new browser.

@hellfire103
Copy link

How's it looking?

@hj-collab
Copy link

hj-collab commented Oct 16, 2024

@vvolkgang @fedemkr Please give some priority to this issue. A whole set of users are not able to use passkeys because your team forgot to include Firefox Nightly in the allowed browsers list. We have Chrome canary in the list but not firefox nightly.

Why user choice is being taken away in the first place? Why should I only use the browsers mentioned in the list?

It feels like the team's priority is to make meaningless design changes instead of fixing the bugs which are significantly hammering the usuability.

@vvolkgang
Copy link
Member

vvolkgang commented Oct 17, 2024

👋🏾 We're following Google's security guidelines and API requirements, as documented here: https://developer.android.com/identity/sign-in/credential-provider#obtain-allowlist

In the new bitwarden/android repository we recently improved this approach by creating a community supported allow list file where you'll find some of the browsers previously mentioned in this thread and are also free to contribute to with additional browsers:

https://github.com/bitwarden/android/blob/main/app/src/main/assets/fido2_privileged_community.json

@hj-collab
Copy link

@vvolkgang Thanks for the update. I am sorry for being harsh. Will look forward to release of the new bitwarden android app.

@bb010g
Copy link

bb010g commented Oct 19, 2024

@vvolkgang I'm glad to see the new process for the rewrite. Could allowlist changes from there be mechanically backported to here until the original app is deprecated?

@Snuupy
Copy link

Snuupy commented Oct 24, 2024

👋🏾 We're following Google's security guidelines and API requirements, as documented here: https://developer.android.com/identity/sign-in/credential-provider#obtain-allowlist

In the new bitwarden/android repository we recently improved this approach by creating a community supported allow list file where you'll find some of the browsers previously mentioned in this thread and are also free to contribute to with additional browsers:

https://github.com/bitwarden/android/blob/main/app/src/main/assets/fido2_privileged_community.json

Hi, this list should not be hardcoded (even if done through community sourcing), instead there should be a user setting to add browser package names to the list in the app that is passed onto the API. Defaults can be provided but should not be the end all be all.

What happens if another browser is created? Users have to wait for it to be added to the community whitelist? Why not make it user configurable, and you can keep the(default) whitelist if you want to?

@yoyo930021
Copy link

yoyo930021 commented Nov 1, 2024

In fact, the Firefox Nightly org.mozilla.fenix mentioned in this issue still hasn’t been added to the allowed list?​

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants