Skip to content

Conversation

@neuronull
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-28826

๐Ÿ“” Objective

While working on enabling easier access to the dev logs, I realized that we aren't building the desktop artifacts in Build Desktop workflow with the NODE_ENV=development flag. The result is that even if you set RUST_LOG=debug , the logs don't make it to the on-disk file because they are filtered out at the electron level.

This change builds the desktop artifacts with the dev flag.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@neuronull neuronull self-assigned this Nov 26, 2025
@neuronull neuronull added the desktop Desktop Application label Nov 26, 2025
@github-actions
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 12192a99-5a55-479c-a956-d76f73f4063a

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Desktop Application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants