[PM-8217] New device two factor notice #4508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/values/strings.xml
…. Add modifier parameter for composables.
…otice-ui-twofa # Conflicts: # app/src/main/res/values/strings.xml
…warden/android into pm-8217/new-device-notice-ui
# Conflicts: # app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeEmailAccessViewModelTest.kt
…vice-notice-navigation
# Conflicts: # app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeTwoFactorViewModel.kt # app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeTwoFactorScreenTest.kt
…e-notice-navigation
# Conflicts: # app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4508 +/- ##
==========================================
- Coverage 88.89% 88.84% -0.05%
==========================================
Files 460 460
Lines 39772 39864 +92
Branches 5647 5676 +29
==========================================
+ Hits 35356 35419 +63
- Misses 2444 2459 +15
- Partials 1972 1986 +14 ☔ View full report in Codecov by Sentry. |
andrebispo5
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8217
📔 Objective
Adds navigation to the new device two factor notice pages.
Includes logic to have a display status linked to the current user.
Adds and updates tests.
Remind me later button is hidden by permanent feature flag.
Screenshot
Permanent feature flag on:
Permanent feature flag off:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes