Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm 6701/email verification selfhost registration #3336

Draft
wants to merge 1,431 commits into
base: main
Choose a base branch
from

Conversation

vvolkgang
Copy link
Member

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

david-livefront and others added 30 commits April 2, 2024 13:55
Co-authored-by: David Perez <david@livefront.com>
david-livefront and others added 28 commits June 13, 2024 08:44
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…tion

# Conflicts:
#	.github/workflows/scan.yml
#	app/build.gradle.kts
#	app/src/main/java/com/x8bit/bitwarden/BitwardenApplication.kt
#	app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt
#	app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt
#	app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/di/PlatformDiskModule.kt
#	app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/di/PlatformNetworkModule.kt
#	app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/retrofit/Retrofits.kt
#	app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/retrofit/RetrofitsImpl.kt
#	app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingNavigation.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreen.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModel.kt
#	app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanViewModel.kt
#	app/src/main/res/values/strings.xml
#	app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt
#	app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/retrofit/RetrofitsTest.kt
#	app/src/test/java/com/x8bit/bitwarden/data/platform/manager/AppForegroundManagerTest.kt
#	app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreenTest.kt
#	app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanViewModelTest.kt
#	build.gradle.kts
#	gradle/libs.versions.toml
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details4a559aaa-39ab-4119-ac10-d152166948dd

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: [304](https://github.com/bitwarden/android/blob/pm-6701/email-verification-selfhost-registration//app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt# L304) Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: [304](https://github.com/bitwarden/android/blob/pm-6701/email-verification-selfhost-registration//app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt# L304) Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: [296](https://github.com/bitwarden/android/blob/pm-6701/email-verification-selfhost-registration//app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt# L296) Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: [296](https://github.com/bitwarden/android/blob/pm-6701/email-verification-selfhost-registration//app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt# L296) Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: [222](https://github.com/bitwarden/android/blob/pm-6701/email-verification-selfhost-registration//app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt# L222) Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: [211](https://github.com/bitwarden/android/blob/pm-6701/email-verification-selfhost-registration//app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt# L211) Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: [201](https://github.com/bitwarden/android/blob/pm-6701/email-verification-selfhost-registration//app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt# L201) Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: [200](https://github.com/bitwarden/android/blob/pm-6701/email-verification-selfhost-registration//app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt# L200) Attack Vector

oguzhane pushed a commit to oguzhane/nibblewarden that referenced this pull request Jul 23, 2024
…itwarden#3336)

* Update bug.yml to reference the new native apps

* Replacing table with a GitHub Alert.

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

* Added Alert to README

* Fix template syntax error

* Improved bug templated and added config links

* Update .github/ISSUE_TEMPLATE/config.yml

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants