Skip to content

# Fix for matmul_4bit out Parameter Issue #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ved1beta
Copy link
Contributor

fix: matmul_4bit out parameter handling for 1D and 2D tensors

  • Fix incorrect handling of out parameter in matmul_4bit for 1D tensors
  • Improve shape validation in gemv_4bit.out to handle 1D tensor cases
  • Ensure proper tensor reshaping and memory handling in CUDA kernels
  • Update conditional logic in matmul_4bit to consistently handle OUT parameter

This fixes GitHub issue #1235 where the out parameter was not working correctly
for matrix multiplication operations, particularly with 1D input tensors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant