Polish GitHub workflows #1116
Merged
Polish GitHub workflows #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akx
commented
Mar 8, 2024
•
akx
commented
- move long shell scripts to separate files (and run shellcheck and shfmt on them)
- reformat workflows with Prettier
- add a commented-out test step
- making this work requires Rework CUDA/native-library setup and diagnostics #1041 to get merged first, and we'll then need to ensure bnb loads the CPU library instead of giving up entirely when Torch is CUDA enabled, but there is no CUDA hardware
- add audit-wheel step (adapted from add audit wheel to CI/CD for visibility of many_linux conformance #1114). Closes add audit wheel to CI/CD for visibility of many_linux conformance #1114 (supersedes it)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
akx
force-pushed
the
split-build
branch
3 times, most recently
from
84565bf
to
09c8375
Compare
akx
force-pushed
the
split-build
branch
5 times, most recently
from
ce89bca
to
beb2b66
Compare
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <9048635+Titus-von-Koeller@users.noreply.github.com>
Titus-von-Koeller
merged commit ce597c6
into
bitsandbytes-foundation:main
23 checks passed
|
Thanks @akx, great work as always and very helpfully targeted! Went through everything and everything looks %100. Thanks for pointing out the error with the version mismatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.