-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "install from source" instructions #1042
Comments
Great catch @MatthiasKohl I can confirm this works perfect, would you be happy to fix the installation.md file on the docs? https://github.com/TimDettmers/bitsandbytes/blob/main/docs/source/installation.mdx otherwise I can do it as well |
@younesbelkada Thank you so much for fixing this so quickly ! I'd love to contribute, but I'm on CET, so I wasn't available anymore yesterday late in the evening. I'll give it a shot next time. |
System Info
Applies to all CUDA platforms
Reproduction
Run the following instructions as given by the error output in the latest NVIDA NGC PyTorch container:
--> these instructions won't install CUDA-enabled bitsandbytes. BTW, python setup.py has been obsolete for a long time.
Run the following instructions as given by https://huggingface.co/docs/bitsandbytes/main/en/installation#from-source:
--> still won't give a CUDA insall, BUILD_CUDA is not a CMake option used by this project, and the build folder is useless to
pip install
Expected behavior
The install instructions here: https://huggingface.co/docs/bitsandbytes/main/en/installation#from-source
Are incorrect AFAICT:
Somewhat related issue: #1040
-DBUILD_CUDA=ON
doesn't seem to exist given CMakeLists , it should be-DCOMPUTE_BACKEND=[cpu|cuda|mps]
-B build
is confusing since thesetup.py
isn't looking in that folder by default. In fact,setup.py
looks in the main repo folder by default, which is odd since this means one has to build in-place, something that's fairly rare for python extensions. If this should stay that way, at least change the default instruction to-B .
-DCOMPUTE_CAPABILITY=native
to pass the flag-arch=native
to NVCC, then use that as a defaultmake
orcmake --build
So the final install isntructions I'd suggest at the moment is:
and ultimately, it would be nice to get to this (cannot work with the current CMakeLists):
The text was updated successfully, but these errors were encountered: